A special page used as main page is displayed instead of any diff missing both title and curid parameters
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Nikerabbit
	Sep 22 2013, 5:41 PM

Description

Set mediawiki:mainpage to Special:SpecialPages
Follow rc link from irc output like https://dev.translatewiki.net/w/i.php?oldid=500706&rcid=832769

Observed: special:specialpage loads
Expected: the diff

Version: 1.22.0
Severity: major

Mentioned Here: rMW861f5a0f32f6: *Don't fuck over special pages with oldid param

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:10 AM

• bzimport set Reference to bz54452.

• bzimport added a subscriber: Unknown Object (MLST).

Aaron, can you explain why you excluded special pages in commit 861f5a0f32f6b87063eb2c2f97b1706cf26f272a?

I can workaround this in Wiki.php:

if ( is_null( $ret ) || !$ret->isSpecialPage() || $ret->equals( Title::newMainPage() ) {

But is there a better solution?

(In reply to comment #1)

Aaron, can you explain why you excluded special pages in commit
861f5a0f32f6b87063eb2c2f97b1706cf26f272a?

This link doesn't work and Aaron doesn't seem to be copied on this bug report.

Of course it doesn't not work as it was not meant to be a link. Here is a link: https://www.mediawiki.org/w/index.php?title=Special:Code/MediaWiki/23573

Aaron was not in CC because you edit conflicted with me in this bug.

Aaron: can you check the question above?

Clarifying summary. Steps to reproduce:

Expected: if the diff and oldid IDs are not deleted, the diff is shown.
Actual: Special:MainPage is shown.

Steps to reproduce:

Let's try again:

Step to reproduce:

Edit MediaWiki:MainPage in your wiki to say Special:SpecialPages
Go to Special:RecentChanges of your wiki and open any diff link
Remove curid and title parameters to match the links generated by RC UDP feed commonly relayed to IRC channels

Observed: Special:SpecialPages is shown
Expected: The diff is shown

Test this on your own wiki, not at (dev.)translatewiki.net!

Change 86381 had a related patch set uploaded by Nikerabbit:
Move 'main page as default title' further down to unbreak diff urls

Change 86381 merged by jenkins-bot:
Move 'main page as default title' further down to unbreak diff urls