Page MenuHomePhabricator

Missing message <api-error-stasherror> in connection with the UploadWizard
Closed, ResolvedPublic

Description

Screenshot

During uploading files with the UploadWizard I saw a placeholder for the missing message <api-error-stasherror>.

Filing this bug into core because the API error messages are in MessagesEn.php.


Version: master
Severity: normal
Whiteboard: gci2013
URL: http://www.google-melange.com/gci/task/view/google/gci2013/5854794258317312
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54028

Attached:

UW_-_Missing_message.PNG (552×908 px, 78 KB)

Details

Reference
bz54460

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:10 AM
bzimport set Reference to bz54460.
bzimport added a subscriber: Unknown Object (MLST).

I have no idea why these errors are in core, but they don't actually belong to the API, despite the names given them.

Apparently they were added in r108415 by Siebrand with a comment "Remove API error message duplication from Translate and UploadWizard into core", so they rightly belong to one of those two extensions. Since the bug says the missing message was seen in UploadWizard, let's put it there.

Adding many blockers of bug 38638 to the list of "easy" bugs, to mark them as candidates for [[mw:Google Code-in]] tasks (gci2013). If you think this bug is not suitable, remove the keyword.

Can be fixed at the same time as bug 54524 comment 4, add Shira to reviewers.

To be clear, are you saying that we can create one single Google Code-in task consisting of bug 54524 comment 4 and this report here?

(In reply to comment #4)

To be clear, are you saying that we can create one single Google Code-in task
consisting of bug 54524 comment 4 and this report here?

mayankmadan says yes. :)

Change 105040 had a related patch set uploaded by Mayankmadan:
Adding a message for api-error-stasherror

https://gerrit.wikimedia.org/r/105040

Change 105040 abandoned by Mayankmadan:
Adding a message for api-error-stasherror

Reason:
Needs to be in core

https://gerrit.wikimedia.org/r/105040

Change 105094 had a related patch set uploaded by Mayankmadan:
Adding a message for api-error-stasherror

https://gerrit.wikimedia.org/r/105094

Change 105097 had a related patch set uploaded by Mayankmadan:
Including api-error-stasherror from core

https://gerrit.wikimedia.org/r/105097

Change 105094 merged by jenkins-bot:
Adding a message for api-error-stasherror

https://gerrit.wikimedia.org/r/105094

Change 105097 merged by jenkins-bot:
Including api-error-stasherror from core

https://gerrit.wikimedia.org/r/105097

All patches merged - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.