Grepping through the code shows no use of this variable outside of its declaration. It certainly doesn't remove the login link.
Version: master
Severity: normal
Description
Description
Details
Details
- Reference
- bz54506
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Feature | None | T66475 Make crosswiki bits and pieces truly global (tracking) | ||
| Declined | Feature | None | T15631 Wikimedia should become an OpenID provider | ||
| Declined | None | T31254 [SUGGESTION] Expose group memberships for query through OpenID teams extension | |||
| Declined | Wikinaut | T25735 Allow different user grouping for OpenID users | |||
| Declined | None | T61631 Enable Facebook login on Wikimedia wikis | |||
| Declined | None | T11604 Get OpenID extension to a state where it could be used on Wikimedia projects as a provider | |||
| Resolved | Wikinaut | T56506 $wgHideOpenIDLoginLink was not completely renamed to $wgOpenIDHideOpenIDLoginLink |
Event Timeline
Comment Actions
It looks like the name was changed to $wgHideOpenIDLoginLink. Setting $wgHideOpenIDLoginLink=true hides the link correctly. https://www.mediawiki.org/wiki/Extension:OpenID#Configuration references the correct name.
Comment Actions
Thanks for reporting.
All OpenID parameter names should have the form $wgOpenID......
It appears, that the renaming of this specific variable has been overlooked in the past. I will fix this begin of October.
Sorry for the inconvenience.
Comment Actions
The bug is still a bug, it's not invalid. If the name should be $wgHideOpenIDLoginLink, then that should be listed in OpenID.php and $wgOpenIDHideOpenIDLoginLink shouldn't be. And if the name should be $wgOpenIDHideOpenIDLoginLink, then $wgHideOpenIDLoginLink needs to be replaced in the code and the documentation.
Comment Actions
solved with https://gerrit.wikimedia.org/r/#/c/87321/ (why is gerrit not adding this information any more ?)
Comment Actions
(In reply to comment #5)
solved with https://gerrit.wikimedia.org/r/#/c/87321/ (why is gerrit not
adding this information any more ?)
Because you did not follow http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines
Comment Actions
http://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines :
added there "No text must follow the bugnumber. "