Page MenuHomePhabricator

VisualEditor: Rendering of <source> MWExtensionNode is empty after the user edits it
Closed, ResolvedPublic

Description

  1. Create a page with <source lang="JavaScript">some content here</source>
  2. Edit the page in VE. Note that the <source> tag renders correctly
  3. Use the alien tag inspector to edit the contents of the <source> tag
  4. The <source> tag rerenders as an empty block

This is because the HTML <source> tag is self-closing and cannot have any content. This leads to strange situations like:

extensionNode[0]

<source lang=​"JavaScript">​whee​</source>​

extensionNode[0].outerHTML

"<source lang="JavaScript"></source>"

To avoid the HTML behavior for this and possibly other tag names, we should create an XML node rather than an HTML node to build the wikitext string for the preview.


Version: unspecified
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=57429

Details

Reference
bz54577

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:12 AM
bzimport set Reference to bz54577.

Change 98392 had a related patch set uploaded by Esanders:
Render MW extension node wikitext with XML

https://gerrit.wikimedia.org/r/98392

Change 98392 merged by jenkins-bot:
Render MW extension node wikitext with XML

https://gerrit.wikimedia.org/r/98392