Page MenuHomePhabricator

VisualEditor: Inserting a reference breaks up annotations around it
Open, MediumPublic

Description

When you insert a reference in the middle of a bolded word, the reference itself doesn't receive a bold annotation, and so the resulting text is something like '''He'''<ref name="hello" />'''llo''', with the bold breaking around the reference.

When we insert inline nodes like references from the UI, they should take annotations. This is probably a wider problem beyond just references.


Version: unspecified
Severity: normal

Details

Reference
bz54587

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:13 AM
bzimport set Reference to bz54587.

The dialogs generate insertion transactions directly with newFromInsertion, and have no insertion annotation logic.

Also, I'm not sure this is desirable behaviour.

(In reply to comment #2)

Also, I'm not sure this is desirable behaviour.

But we are. :-)

Jdforrester-WMF lowered the priority of this task from High to Medium.Jan 9 2015, 10:55 PM