Page MenuHomePhabricator

Incorrect signs via numerical keypad on de.wp in Source Editor
Closed, ResolvedPublic

Description

Author: benninghaus

Description:
If I put in signs with <ALT>+Number on Numerical Keypad there is shown e.g.:
"0150–", instead of "–".

I have this editing problem only when using Firefox 24.0, not with use under Opera 12.19 or Internet Explorer 64-bit 10.09.


Version: unspecified
Severity: normal
OS: Windows 7
Platform: PC

Details

Reference
bz54646

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:17 AM
bzimport set Reference to bz54646.

Is this with the source editor or the visual editor? Can you provide a link to an edit page that shows this problem?

I can't reproduce the described problem on en.wikipedia.org with either the source or visual editor on Windows 8 64-bit & Firefox 24; I see just the "–".

benninghaus wrote:

In deed: I can reproduce it only on de.wikipedia.org, but not on en., fr. or nl.wikipedia.org. There's only a source editor on de.wikipedia.org.

System used: Windows Professionell 7 64-bit

benninghaus wrote:

The bug is reproducable on all de.wikipedia.org-pages, but not on other wikimedia-sites like commons.

I miss a keyboard with numpad to reproduce. :-/

Is there any output in the Tools > Web Developer > Browser Console?
If this only happens on de.wp it might be some local script...

mr.heat wrote:

I can't reproduce this. But I have the feeling it may be caused by the "Input tools" and/or the "Language settings" (German: "Eingabewerkzeuge" und/oder "Spracheinstellungen"). Please try to disable them. Note: It's not in the settings. You need to click the little keyboard icon at the end of the editor or the gear icon in the sidebar on the left.

benninghaus wrote:

It's been. Thank's very much!

Yeah, works for me now, too. Must be a bug in the option for German in the language tool.

mr.heat wrote:

I can reproduce this in all projects and all languages with every non-native input method. It happens in Firefox and Opera 12. It does not happen in IE 9.

Steps to reproduce:

  1. Go to the English Wikipedia.
  2. Click the gear icon next to "Languages".
  3. Enable the "Input tools".
  4. Choose "Deutsch" > "Deutsch" (not "Use native keyboard").
  5. Edit the source (don't use Visual Editor) of a random article.
  6. Type Alt+0150.

Same problem with every non-native input method, e.g. "English" > "International Phonetic Alphabet - SIL" and "English" > "International Phonetic Alphabet - X-SAMPA".

This is clearly a bug. Whatever the input methods do (there is no documentation, not even an English one), the Alt key is not involved as far as I know.

Besides, that JavaScript monstrosity does not make any sense in the German Wikipedia. It does nothing except for adding confusion and bugs like this (there are far more, e.g. it crashs my [[dewiki:User:TMg/autoFormatter]] for an unknown reason). Please disable it in the German Wikipedia and make it opt-in instead of opt-out.

Thanks for investigating and debugging this. Very appreciated!

(In reply to comment #10)

This is clearly a bug.

Your comment is good till this point. Thanks.

Whatever the input methods do (there is no
documentation, not even an English one), the Alt key is not involved as far
as
I know.

https://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods
The above pages are also linked from the ULS interface.

Besides, that JavaScript monstrosity

This is not helpful. Please don't call names.

It does nothing except for adding confusion and bugs like this
(there are far more, e.g. it crashs my [[dewiki:User:TMg/autoFormatter]] for
an unknown reason).

Please report with steps to reproduce in Bugzilla.

Please disable it in the German Wikipedia and make it opt-in
instead of opt-out.

This doesn't belong here. It is unclear what you refer to with "it", but the default input method for German Wikipedia is "Native keyboard" and you can opt-in to use other input methods.

mr.heat wrote:

(In reply to comment #12)

The above pages are also linked from the ULS interface.

I'm sorry? First, there is no German documentation for the German method.

http://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods/de-transliteration

Second, go to the English section and tell me what the two "Phonetic Alphabet" methods do. There is no explanation, not even an English one. Why are these methods there if nobody can use them?

http://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods/ipa-sil
http://www.mediawiki.org/wiki/Help:Extension:UniversalLanguageSelector/Input_methods/ipa-x-sampa

Please report with steps to reproduce in Bugzilla.

I tried for days but can't reproduce it. That's the problem. Multiple users reported random problems with the ULS crashing multiple other scripts. Disabling the ULS always fixed the problem.

the default input method for German Wikipedia is "Native keyboard"

This leads to an other question. Whats the difference between enabling "native" and disabling the input methods completely? Thats an other reason why I call this thing a "monstrosity". It's completely unclear to most users what it does. They choose "German" because they have no idea what it does and they think it must be that way. But almost all German users have a German keyboard with Umlaut keys. They don't need to set this to "German".

So the problem is: Don't call the setting "German". Call it something like "Choose this if you are using a non-German keyboard".

(In reply to comment #13)

I tried for days but can't reproduce it. That's the problem. Multiple users
reported random problems with the ULS crashing multiple other scripts.
Disabling the ULS always fixed the problem.

Disabling "multiple other scripts" or fixing them might also fix the problem (don't know, as I don't know where those other scripts originate from - too vague).

So the problem is: Don't call the setting "German". Call it something like
"Choose this if you are using a non-German keyboard".

This seems to be a different issue and nothing for this bug report. Plus I don't see how renaming a 6 char item to a 50 char item helps with not cluttering the UI. However there might be room for improvement explaining to users what these input methods are actually meant for, and when they are not needed (as you correctly described).

mr.heat wrote:

(In reply to comment #14)

too vague

I really wish I could tell you more but I gave up after three days. Here is the discussion:

https://de.wikipedia.org/wiki/Benutzer_Diskussion:TMg/autoFormatter#Hesperus_oder_45_Hundposttage

Today I spend two more hours debugging. See bug 55701.

different issue

Very true, see bug 55698.

https://github.com/wikimedia/jquery.ime/commit/49d02b602cf303dfde3ca4bb2f509c7a3a44364c may be the cause for this bug. Ideally jquery.ime should skip alt and the numbers after that key since the keyboard definition has no mapping for them. Because of the above code, the alt key is being consumed by jquery.ime and what we get is the numbers.

(In reply to comment #18)

Upstream fix https://github.com/wikimedia/jquery.ime/pull/310

This one breaks the Udmurt keyboard layout, but this other upstream fix is probably better:
https://github.com/wikimedia/jquery.ime/pull/312

I haven't tested it myself, however.