Maniphest T56679

PLURAL support for Coll-load local book
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Siddhartha-Ghai
	Sep 27 2013, 5:21 AM

Tags

Referenced Files

None

Subscribers

Description

Reporting this bug per an old translatewiki thread[1], the message [[:w:MediaWiki:Coll-load local book]] doesn't support plural. It needs to support plural over the %NUMPAGES% parameter. This is needed for proper hindi translation of the sentence. Its probably also needed for other languages.

Hindi translation won't require support for plural over %TITLE% but I can't say if other languages may need this support.

[1]: http://translatewiki.net/wiki/Thread:Support/PLURAL_support_for_Coll-load_local_book

Version: unspecified
Severity: normal

Details

Reference: bz54679

	Subject	Repo	Branch	Lines +/-
	Use plural and remove legacy code	mediawiki/extensions/Collection	master	+1 -3

Customize query in gerrit

Related Objects

Mentioned In: rECOL5a3266782cf9: Use plural and remove legacy code
rMEXTac514e468b3e: Updated mediawiki/extensions Project: mediawiki/extensions/Collection…

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:20 AM

• bzimport added a project: Collection.

• bzimport set Reference to bz54679.

• bzimport added a subscriber: Unknown Object (MLST).

Siddhartha-Ghai created this task.Sep 27 2013, 5:21 AM

While here, we should get rid of horrible %TITLE% handling with parens:

21 txt = txt.replace(/%TITLE%/, c.title ? '("' + c.title + '")' : '');
22 txt = txt.replace(/%NUMPAGES%/, num_pages);

It gets worse - check out where the 'txt' variable comes from.

Liuxinyu970226 subscribed.Dec 27 2014, 1:28 PM

Change 224959 had a related patch set uploaded (by Siebrand):
Use plural and remove legacy code

https://gerrit.wikimedia.org/r/224959

gerritbot added a project: Patch-For-Review.Jul 15 2015, 9:35 PM

For demo session Hackathon

Change 224959 merged by jenkins-bot:
Use plural and remove legacy code

https://gerrit.wikimedia.org/r/224959

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 8:25 AM

siebrand mentioned this in rMEXTac514e468b3e: Updated mediawiki/extensions Project: mediawiki/extensions/Collection….Sep 10 2015, 8:25 AM

siebrand mentioned this in rECOL5a3266782cf9: Use plural and remove legacy code.

Liuxinyu970226 set Security to None.Sep 10 2015, 1:33 PM

ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 10:02 PM

• Purodha subscribed.Jan 26 2016, 8:11 AM

Is not this bug fixed by now and should be closed as fixed? Need to update /qqq though.

Jdlrobson closed this task as Resolved.Sep 7 2017, 2:38 PM

Jdlrobson claimed this task.

Liuxinyu970226 unsubscribed.Sep 14 2017, 2:15 PM

MarcoAurelio added a project: Plural-Support.Jan 6 2018, 12:17 PM

MarcoAurelio removed a subscriber: • wikibugs-l-list.

MarcoAurelio removed a parent task: T40781: [DO NOT USE] Messages needing PLURAL support (tracking) [superseded by #Plural-Support].Jan 6 2018, 12:22 PM