Page MenuHomePhabricator

Clean up config flags from SUL2 migration
Closed, ResolvedPublic

Description

During the SUL2 migration, we created several feature flags to account for wikis running different versions of CentralAuth, and only having some wikis aware of loginwiki, all while still providing single sign-on to all projects.

Some of that code has caused confusion while trying to debug issues that turned out to be unrelated. It would be good to remove:

  • flags and code paths for $wgCentralAuthSilentLogin and $wgCentralAuthUseOldAutoLogin
  • SpecialAutoLogin.php

Version: master
Severity: normal

Details

Reference
bz54808

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:28 AM
bzimport set Reference to bz54808.

Change 69312 had a related patch set uploaded by Anomie:
Remove $wgCentralAuthSilentLogin, defaulted to true

https://gerrit.wikimedia.org/r/69312

Change 64253 had a related patch set uploaded by Anomie:
Remove Special:AutoLogin

https://gerrit.wikimedia.org/r/64253

Change 69312 merged by jenkins-bot:
Remove $wgCentralAuthSilentLogin, defaulted to true

https://gerrit.wikimedia.org/r/69312

Change 64253 merged by jenkins-bot:
Remove Special:AutoLogin

https://gerrit.wikimedia.org/r/64253