Page MenuHomePhabricator

$wgDisableCounters is used for two independent functions (disabling site counters and displaying counters as they are)
Closed, InvalidPublic

Description

Author: Volodya

Description:
$wgDisableCounters is used for two independent functions (partially thanks to bug 17795). The first one is disabling site counters (which is what's expected), the second one is displaying counters as they are (which is not expected in some situations (see below)).

For example, if http://www.mediawiki.org/wiki/Extension:SysopDisableSiteCounters is installed it disables the counters *for the specific user*, and that means that this user all of the sudden cannot view the counter as well. This is *not* expected, and requires hacks to the MediaWiki software to re-enable the display again.

What we need is a second variable: <code>$wgEnableCounterDisplay=true;</code> (no need for double negatives) in DefaultSettings.php.


Version: 1.21.x
Severity: minor

Details

Reference
bz54819

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:29 AM
bzimport set Reference to bz54819.

Change 139114 had a related patch set uploaded by Rohan013:
Fix for bug 54819, adds $wgEnableCounterDisplay variable in DefaultSettings.php

https://gerrit.wikimedia.org/r/139114

Change 139114 had a related patch set uploaded by Rohan013:
Add $wgEnableCounterDisplay variable in DefaultSettings.php

https://gerrit.wikimedia.org/r/139114

Umherirrender subscribed.

$wgDisableCounters was removed with I0e5006a7e8a09c800f8fa4effa9399e8afdd7a57 - https://gerrit.wikimedia.org/r/#/c/150699/