Page MenuHomePhabricator
Create Task
Maniphest T56878

Proximity search doesn't highlight nor sometimes show matching text
Closed, ResolvedPublic
Actions

Description

The search in the URL ("femminile di"~2) gives me this as top results:

flessa
Italiano Aggettivo, forma flessa flessa f sing singolare
3 KB (509 parole) - 17:01, 9 lug 2013

note
Italiano Aggettivo, forma flessa note f pl singolare plurale
12 KB (1 793 parole) - 18:53, 7 lug 2013

italiana
Italiano Aggettivo, forma flessa italiana f sing singolare
7 KB (1 098 parole) - 03:30, 9 lug 2013

derivate
Italiano Aggettivo, forma flessa derivate f pl singolare
4 KB (634 parole) - 13:45, 9 lug 2013

quella
Italiano Aggettivo, forma flessa quella f sing femminile di quello
3 KB (499 parole) - 07:03, 8 lug 2013

All of them are correct pages, but the first 4 don't show the matching text in the snippet. Additionally, none of them is highlighted.

Reported at https://it.wiktionary.org/w/index.php?title=Wikizionario:Bar&diff=1543867&oldid=1543832

Version: master
Severity: normal
URL: https://it.wiktionary.org/w/index.php?title=Speciale%3ARicerca&profile=default&search=%22femminile+di%22~2&fulltext=Search
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=54526

Details

Reference
bz54878

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:33 AM
• bzimport added a project: CirrusSearch.
• bzimport set Reference to bz54878.
• bzimport added a subscriber: Unknown Object (MLST).
Nemo_bis created this task.Oct 2 2013, 3:17 PM
• Manybubbles added a comment.Oct 2 2013, 3:31 PM

This is known already (Bug: 54526) but I'm going to usurp this bug to write a work around that works for queries like yours.

gerritbot added a comment.Oct 2 2013, 6:00 PM

Change 87177 had a related patch set uploaded by Manybubbles:
Tests for workaround of highlighting issue.

https://gerrit.wikimedia.org/r/87177

gerritbot added a comment.Oct 2 2013, 6:07 PM

Change 87179 had a related patch set uploaded by Manybubbles:
Highlight both plain and stemmed fields.

https://gerrit.wikimedia.org/r/87179

gerritbot added a comment.Oct 2 2013, 6:08 PM

Change 87177 merged by jenkins-bot:
Tests for workaround of highlighting issue.

https://gerrit.wikimedia.org/r/87177

• Manybubbles added a comment.Oct 2 2013, 6:09 PM

So patch that I've pushed for this bug will highlight the result twice:
once with the strict matches that you get from a phrase match and one with the stemmed match you get without it. It'll take the stemmed match if there is one, otherwise it'll give you the strict match. The other bug (Bug 54526) is now officially for highlighting both matches all together.

gerritbot added a comment.Oct 2 2013, 8:48 PM

Change 87179 merged by jenkins-bot:
Highlight both plain and stemmed fields.

https://gerrit.wikimedia.org/r/87179

• Manybubbles added a comment.Oct 2 2013, 8:50 PM

This has been merged. It's an improvement but not a real fix. See Bug 54526 for the real fix.

Nemo_bis added a comment.Oct 2 2013, 8:58 PM

Thanks!

• Manybubbles added a comment.Oct 2 2013, 11:56 PM

Verified on itwiktionary with the provided query. That query, at least, has highlighting.

• Deskana moved this task from Inbox to Resolved/Invalid/Declined/Legacy on the CirrusSearch board.Apr 20 2015, 4:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL