VisualEditor: Make the isRedirect disable check look at the revision being considered, not current revision
Closed, InvalidPublic
Actions

Assigned To

None

Authored By

	Thryduulf
	Oct 3 2013, 3:15 PM

Description

When a page is currently a redirect, but has none-redirect versions in its history those versions should be editable in VE but are not. e.g. https://en.wikipedia.org/w/index.php?title=Equality_Acts&oldid=570457856

To reproduce:

Load any page that is not a redirect in the source editor
Change the page into a redirect and save
View any revision prior to the redirect

Expected behaviour: Old version is editable in VE
Action behaviour: No option is given to edit in VE

Version: unspecified
Severity: minor
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=50878

Details

Reference: bz54921

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:37 AM

• bzimport added projects: VisualEditor-MediaWiki, good first task.

• bzimport set Reference to bz54921.

Thryduulf created this task.Oct 3 2013, 3:15 PM

Will be superseded by bug 50878 once bug 47328 is implemented, but could be done sooner if someone is keen.

I'm not sure how easy this would be to do... It appears to be based on MediaWiki core's wgIsRedirect, which would need fixing to work out whether the current revision is a redirect (instead of the latest revision of the current page). I'm not sure core even has a function to work that out at the moment. Even in the database, the field to determine if something is a redirect is in the page table instead of the revision table.

We no longer stop editing of isRedirect pages, so marking as INVALID now.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:06 AM

VisualEditor: Make the isRedirect disable check look at the revision being considered, not current revisionClosed, InvalidPublicActions

Description

Details

Event Timeline

VisualEditor: Make the isRedirect disable check look at the revision being considered, not current revision
Closed, InvalidPublic
Actions