Page MenuHomePhabricator

Variable GRAMMAR for Slovene language: mestnik, orodnik cases include prepositions
Open, LowPublic

Description

Author: dejan.papez

Description:
Hi, the GRAMMAR variable for Slovene language, the cases 'mestnik' and 'orodnik', currently includes the prepositions (o and z). These depend on the context and should therefore be left out of the default pattern.

Mestnik:

  • o Wikipediji > Wikipediji

Orodnik:

  • z Wikipedijo > Wikipedijo

Etc.

Thank you.


Version: 1.22.0
Severity: normal

Details

Reference
bz54958

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:39 AM
bzimport set Reference to bz54958.
bzimport added a subscriber: Unknown Object (MLST).

dejan.papez wrote:

It doesn't seem:

Locativ: "word = 'o ' . $word" - this "o" is redundant
Instrumental: "word = 'z ' . $word;" - this "z" is redundant

mitenem wrote:

Removed hard-coded prepositions from grammar function

Patched file https://git.wikimedia.org/raw/mediawiki%2Fcore.git/HEAD/languages%2Fclasses%2FLanguageSl.php.

Attached:

mitenem wrote:

Removed prepositions from Slovene grammar forms

Patched file http://git.wikimedia.org/blob/mediawiki%2Fextensions%2FWikimediaMessages.git/HEAD/WikimediaGrammarForms.php.

(I also saw that 'rmy' language uses Slovene grammar forms for dative, locative, ablative and instrumental, which is probably a copy-paste error.)

Attached:

mitenem wrote:

I have uploaded two patches that fix this bug.

mitenem wrote:

I just saw that my patched LanguageSl::convertGrammar() is same as Language::convertGrammar(), so file languages/classes/LanguageSl.php can be completely removed.

You are very welcome to use developer access to submit this as a Git branch directly into Gerrit.

Putting your branch in Git makes it easier to review it quickly. If you don't want to set up Git/Gerrit, you can also use the Gerrit Patch Uploader.