Page MenuHomePhabricator

UploadWizard hangs browser on entering image description
Closed, ResolvedPublic

Description

Author: pirogronian-c

Description:
While copying this files: https://en.wikipedia.org/wiki/Three-jet_event, https://en.wikipedia.org/wiki/File:Three_jet_photon_string.png, https://upload.wikimedia.org/wikipedia/en/thumb/2/2a/Three_jet_photon_jets.png/120px-Three_jet_photon_jets.png to Commons browser has been frozen after pasting description from oryginal file. Pasting by parts solved problem only in one case. It happened on two different browsers, so I think it's related to script on the page.


Version: master
Severity: normal
OS: Linux
Platform: PC
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=33607

Details

Reference
bz54994

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM
bzimport added a project: UploadWizard.
bzimport set Reference to bz54994.

Thanks for taking the time to report this!

How do I copy? (Or in different words: Which steps would I have to follow to reproduce the problem?)

pirogronian-c wrote:

(In reply to comment #1)

Thanks for taking the time to report this!

How do I copy? (Or in different words: Which steps would I have to follow to
reproduce the problem?)

  1. Go to url http://commons.wikimedia.org
  2. Click on "Upload file" (left side)
  3. At step 2 ("Upload") upload any(?) file. I've uploaded files listed in description of bug.
  4. At step 3 ("release rights") check any(?) license, I've checked Creative Commons Attribution 3.0.
  5. Go to (in other tab or window) any file listed in my description.
  6. Click "Edit".
  7. Copy all content with exclusion of last line.
  8. Go to Upload wizard at step 4 ("Description") and paste clipboard content into "Description" input field.

Now your browser should be hangs in infinity loop (I checked it with system monitor).

In practice Wizard won't allow upload this same file again, so while reproduction it must be diffrent test image.

pirogronian-c wrote:

Looks very similar, although in that case people focused on length of pasting/typing text. In my case, it sometimes didn't appeared while pasting whole text in parts. But sometimes it did. But it may be the same bug anyway.

Thanks for reporting this issue.

But we need more info to investigate further:

  • What browser were you using?
  • What was the exact description you were trying to paste?

Moving this to normal for now, adding 33607 as possible 'see also' -- and will revisit later, once we have more info.

pirogronian-c wrote:

(In reply to comment #5)

Thanks for reporting this issue.

But we need more info to investigate further:

  • What browser were you using?
  • What was the exact description you were trying to paste?

Moving this to normal for now, adding 33607 as possible 'see also' -- and
will
revisit later, once we have more info.

Tested on firefox and Konqueror.

Descriptions may be found in links at first post, although that files are already deleted. Its duplicates with descriptions can by found on commons. Here is example:
"Diagram of two quarks and a photon, for comparison with [[:Image:Three_jet_gluon_string.jpg]]. Created by [[User:SCZenz|SCZenz]].
{{GFDL-with-disclaimers|migration=relicense}}

{{artifacts}}

History of Image:Three jet photon string.jpg

*2007-05-07T21:18:05Z [[User:Cydebot|Cydebot]] ([[User talk:Cydebot|Talk]] | [[Special:Contributions/Cydebot|contribs]]) (168 bytes) ''(<nowiki>Robot - Fixing GFDL tags project-wide per [[Wikipedia:GFDL standardization]].</nowiki>)''
*2007-04-10T21:44:07Z [[User:Keenan Pepper|Keenan Pepper]] ([[User talk:Keenan Pepper|Talk]] | [[Special:Contributions/Keenan Pepper|contribs]]) ''(<nowiki>{{BadJPEG}}</nowiki>)'' *2005-08-30T04:09:59Z [[User:SCZenz|SCZenz]] ([[User talk:SCZenz|Talk]] | [[Special:Contributions/SCZenz|contribs]])
*2005-08-30T04:09:27Z [[User:SCZenz|SCZenz]] ([[User talk:SCZenz|Talk]] | [[Special:Contributions/SCZenz|contribs]]) ''(<nowiki>Diagram of two quarks and a photon, for comparison with [[Image:Three_jet_gluon_string.jpg]]. Created by [[User:SCZenz|SCZenz]].
{{GFDL}}</nowiki>)''"

(In reply to comment #6)

Tested on firefox and Konqueror.

Please always provide version information. Thanks! :)

pirogronian-c wrote:

(In reply to comment #7)

(In reply to comment #6)

Tested on firefox and Konqueror.

Please always provide version information. Thanks! :)

Firefox 24.o and Konqueror 4.11. Although I suppose that it's independend of version and browser type.

I have just encountered the same problem with Mozilla Firefox 25.0.1 and Google Chrome 31.0.1650.57 m running on Windows 7 Enterprise. I repeated it three times and it hung each time. It happened when I cut and pasted text from a Microsoft Word document into the description text box -- not sure if that is relevant.

The error did not occur when I prepared the text offline using Notepad, and then cut and pasted it into the text box.

(In reply to comment #10)

The error did not occur when I prepared the text offline using Notepad, and
then cut and pasted it into the text box.

Could you please attach the word file you've used that was causing the bug? I've run into javascript bugs before that were related to invisible characters specific to MS Word. Since it seems like it happened every time with your word file, getting our hands on it would probably speed up our ability to reproduce the bug.

Hmmm, I can't remember which Microsoft Word file it was now. But I noticed that the problem happened again recently when I was cutting and pasting text from a website into a text box. Had to shut down Firefox using the Task Manager and restart it.

(In reply to comment #12)

Had to shut down Firefox using the Task Manager

Please see https://support.mozilla.org/en-US/kb/firefox-hangs-or-not-responding - I rather consider it the task of browser developers to not make their software hang due to some (potentially problematic) website content.

pirogronian-c wrote:

(In reply to comment #13)

(In reply to comment #12)

Had to shut down Firefox using the Task Manager

Please see
https://support.mozilla.org/en-US/kb/firefox-hangs-or-not-responding

  • I rather consider it the task of browser developers to not make their

software hang due to some (potentially problematic) website content.

I had it on two different browsers (FF and Konqueror), so it's not browser oriented bug. Not likely.

We really need a sample of content in its original form to be able to reproduce this. Basically we need anyone who's affected by this to give us the file/website they've copied content from and which portion of the text they copied and pasted. The content of the text after it's been pasted isn't enough. Because I have a pretty strong hunch that this has to do with invisible characters that are gone once the description is saved.

I don't think it's (only) due to invisible characters (though perhaps that may sometimes be the cause). I was typing a paragraph of text into the description field -- I estimate it was about five to six lines -- and suddenly the Mozilla Firefox browser (version 26.0) hung. I had to use the Task Manager to end the unresponsive program. In this case, I did not cut and paste the text from any other program.

sandra wrote:

I have had exactly the same problem, for at least five times, using Chrome Version 35.0.1916.114 and Safari Version 7.0.4 (9537.76.4) on OS X 10.9.3.

With trial and error I have tried to find the source of the problem, also thinking it might be due to invisible characters, or perhaps too long chunks of text being pasted.

In some failed uploads I copy-pasted excerpts from, for instance, this webpage:
http://academischecollecties.nl/search?identifier=300.055
(from which the text excerpt 'De duiker met de witte baard omringd door de inlandse bevolking voor een palmhuis.' is copied and then pasted in the upload wizard.

But the bug also occurred to me when I typed the text by hand - no copy-pasting involved.

So I found a way to crash Firefox 31.0 under openSUSE:

  1. Prefill a long description. This can be done by URL or if you fetched a file from Flickr etc.
  2. Resize the textarea to make it wider.
  3. Set the caret at the end of a line visible in the viewport (don't scroll in the textarea).
  4. Insert a [SPACE].

Result: Sometimes an unresponsive script warning that does not fully show up (content of the window is missing) or even nothing -- the browser is just not responding anymore.

Could this be bug 33607 in disguise?

Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:11 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:22 AM