Page MenuHomePhabricator

claimit.py: lang for source lookup
Closed, ResolvedPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/feature-requests/346/
Reported by: apac1
Created on: 2013-08-31 12:40:09.399000
Subject: claimit.py: lang for source lookup
Assigned to: legoktm
Original description:

def setSource(self, lang):

    page = pywikibot.Page(self.repo, 'Wikidata:List of wikis/python')
    source_values = json.loads(page.get())
    source_values = source_values['wikipedia']
    for lang in source_values:
        source_values[lang] = pywikibot.ItemPage(self.repo,
                                                 source_values[lang])

    if lang in source_values:
        self.source = pywikibot.Claim(self.repo, 'p143')
        self.source.setTarget(source_values.get(lang))

The use of lang in "for lang in source_values:" overwrites the lang in "def setSource(self, lang)". This leads to incorrect results. "lang" should be the language of the source wiki. For -cat:"zh:Category:Somevalue" this would be "zh".


Version: unspecified
Severity: enhancement
See Also:
https://sourceforge.net/p/pywikipediabot/feature-requests/346

Details

Reference
bz55000

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:13 AM
bzimport set Reference to bz55000.
bzimport added a subscriber: Unknown Object (????).
  • status: open --> pending
  • assigned_to: Legoktm

In the init part

self.setSource(pywikibot.Site().language())

might also need changing.

Currently, if in the config file there is

family = 'wikipedia'
mylang = 'en'

and claimit is called with

-cat:zh:Category:Somevalue

this leads to "en" to be used, instead of "zh".

(In reply to Kunal Mehta (Legoktm) from comment #3)

In the init part

self.setSource(pywikibot.Site().language())

might also need changing.

This was fixed by Legoktm in

https://gerrit.wikimedia.org/r/#/c/82263/