Page MenuHomePhabricator

adding 'bot' argument for NewpagesPageGenerator()
Closed, ResolvedPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/feature-requests/316/
Reported by: reza1615
Created on: 2012-09-25 14:04:52
Subject: adding bot varable for NewpagesPageGenerator()
Original description:
I don't have developer acount
In pagegenerator.NewpagesPageGenerator\(\) llike wikipedia.newpages\(\) please add bot variable
In pagegenerator.py it need replace line 562-571 with this code

def NewpagesPageGenerator\(number=100, repeat=False, site=None, namespace=0,bot=True\):
"""
Iterate Page objects for all new titles in a single namespace.
"""
\# defaults to namespace 0 because that's how Special:Newpages defaults
if site is None:
site = pywikibot.getSite\(\)
if bot:
for item in site.newpages\(number=number, repeat=repeat, namespace=namespace,
rcshow=\['\!redirect'\]\):
yield item\[0\]
else:
for item in site.newpages\(number=number, repeat=repeat, namespace=namespace,
rcshow=\['\!bot','\!redirect'\]\):
yield item\[0\]


Version: unspecified
Severity: enhancement
See Also:
https://sourceforge.net/p/pywikipediabot/feature-requests/316

Details

Reference
bz55028

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:15 AM
bzimport set Reference to bz55028.
bzimport added a subscriber: Unknown Object (????).
jayvdb subscribed.

Would be good to get this old patch cleaned up and merged in.

Should it be configurable for all generators? E.g. by adding -showbot and -showredir to command line options?

Should it be configurable for all generators? E.g. by adding -showbot and -showredir to command line options?

Yamaha5 set Security to None.
In T57028#946161, @Mpaa wrote:

Should it be configurable for all generators? E.g. by adding -showbot and -showredir to command line options?

sounds good.

Xqt closed this task as Resolved.EditedJul 16 2018, 2:11 PM
Xqt claimed this task.

bot and redirect parameters are already implemented for newpages. Adding this to NewpagesPageGenerator does not make any sense because GeneratorFactory.handleArg cannot retrieve these parameters.