Page MenuHomePhabricator

version.py has a subprocess problem in Windows
Closed, DeclinedPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1654/
Reported by: malafaya
Created on: 2013-08-19 11:05:10.022000
Subject: Non-fatal error starting interwiki.py in Windows
Original description:
It seems that some changes were made to version.py because of git. Under Windows at least, now git.exe seems to be required to be in the PATH.
But, even with git.exe in the PATH, I always get the following error on startup:

'%an' is not recognized as an internal or external command,
operable program or batch file.

It seems to be related to line 122 of version.py, which doesn't seem to work under Windows:

info = subprocess.Popen("git log --pretty=format:'%ad|%an|%h|%H|%d' --abbrev-commit --date=iso -1 | cat -",
                        shell=True,
                        stdout=subprocess.PIPE).stdout.read()

Another problem is that everytime I launch a script, a git.exe process runs and gets stuck. After some few instances, the interwiki.py scripts block and I have to start killing git's.
And, BTW, I don't always have access to the git repository when running scripts (due to some block rules here)

D:\Work\pywikipedia>version.py
'%an' is not recognized as an internal or external command,
operable program or batch file.
Pywikipedia wikipedia.py (r-1 (unknown), 976a310, 2013/08/19, 11:40:07, OUTDATED
)
Python 2.7.5 (default, May 15 2013, 22:44:16) [MSC v.1500 64 bit (AMD64)]
config-settings:
use_api = True
use_api_login = True
unicode test: ok


Version: compat-(1.0)
Severity: minor
See Also:
https://sourceforge.net/p/pywikipediabot/bugs/1654

Details

Reference
bz55128

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:21 AM
bzimport set Reference to bz55128.

are you still facing this problem?

The serious part of it is solved.
The only thing still occuring is that git.exe is still launched (or at least tried to be launched) for version check on every startup with any bot script.
My specific problem is that I don't always have access to the git repo when I run bot scripts, causing a significant delay on startup (or an error if I decide to remove git.exe from PATH).

But in what concerns me I find it acceptable to close this issue at this time if you also find so.

Thank you for your response. I changed priority to lowest but I didn't close it because in my view it's still bug even a little harmless bug

Pywikibot has two versions: Compat and Core. This task was filed about the older version, called Pywikibot-compat, which is not under active development anymore. Hence I'm lowering the priority of this task to reflect the reality. Unfortunately, the Pywikibot team does not have the manpower to retest every single bug report / feature request against the (maintained) Pywikibot code base. Furthermore, the code base of Pywikibot-Compat has changed a lot compared to the code base of Pywikibot-Core so there is a chance that the problem described in this task might not exist anymore. Please help: Unfortunately manpower is limited and does not allow testing every single reported task again. If you have time and interest in Pywikibot, please upgrade to Pywikibot-Core and add a comment to this task if the problem in this task still happens in Pywikibot-Core (or directly edit the task by removing the Pywikibot-compat project and adding the Pywikibot project to this task). To learn more about Pywikibot and to get involved in its development, please check out https://www.mediawiki.org/wiki/Manual:Pywikibot/Development Thank you for your understanding.

Xqt renamed this task from Non-fatal error starting interwiki.py in Windows to version.py has a subprocess problem in Windows.Mar 14 2016, 4:54 PM
Xqt raised the priority of this task from Lowest to Low.

I guess there is a similar problem in core?

Xqt removed jayvdb as the assignee of this task.Mar 22 2019, 12:45 AM

To old. Please reopen if this bug still exists.