Page MenuHomePhabricator

urls ending on a ) incorrectly parsed
Closed, DuplicatePublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1616/
Reported by: harmenhuizinga
Created on: 2013-04-14 09:25:39
Subject: urls ending on a ) incorrectly parsed
Assigned to: amird
Original description:
$ python version.pyPywikipedia \[http\] trunk/pywikipedia \(r11368, 2013/04/13, 08:16:45, ok\)
Python 2.7.3 \(v2.7.3:70274d53c1dd, Apr 9 2012, 20:52:43\)
\[GCC 4.2.1 \(Apple Inc. build 5666\) \(dot 3\)\]
config-settings:
use\_api = True
use\_api\_login = True
unicode test: ok

Weblinks with an \) at the end of the url are handled incorrect by weblinkchecker. That means that the \) is stripped from the url. See example:

$ python weblinkchecker.py -lang:nl -page:Gebruiker:Smile4ever/test
Getting 1 page from wikipedia:nl...
Waiting for remaining 1 threads to finish, please wait...
\*\[\[Gebruiker:Smile4ever/test\]\] links to http://nl.wikipedia.org/wiki/Koe\_\(rund - 404 Not Found.
Saving history...


Version: unspecified
Severity: normal
See Also:
https://sourceforge.net/p/pywikipediabot/bugs/1616

Details

Reference
bz55143

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:22 AM
bzimport set Reference to bz55143.
bzimport added a subscriber: Unknown Object (????).

I made r11378 to fix it, please test it again
I removed parenthesis per http://www.ietf.org/rfc/rfc2396.txt which has considered "\)" as a unreserved character \(means using "\)" at end of the URL causes no harm and It's possible\)
but maybe I'm wrong which means we should do another way \(percent-encoding urls before sending it this URL compiler\)

  • assigned_to: nobody --> amird
  • status: open --> closed-fixed

reopened due to patch \# 3455789, committed code r9797

  • status: closed-fixed --> open-fixed
  • This bug has been marked as a duplicate of bug 54568 ***