Page MenuHomePhabricator

Recentchanges misbehave?
Closed, ResolvedPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1579/
Reported by: Anonymous user
Created on: 2013-02-13 09:41:03
Subject: Recentchanges misbehave?
Original description:
There are two bugs I found in recentchanges\(\) from wikipedia.py.

First, I think that the function should return every revision. However, now it returns only pages that haven't seen before.

Should

if i\['pageid'\] not in seen:
seen.add\(i\['pageid'\]\)

be replaced with

if i\['revid'\] not in seen:
seen.add\(i\['revid'\]\)

?

Second, what does parameter 'includeredirects' stand for? It is useless becaue it isn't used anywhere in the function.

Pywikipedia trunk/pywikipedia/ \(r11072, 2013/02/10, 16:52:07, ok\)
Python 2.7.3 \(default, Sep 26 2012, 21:53:58\)
\[GCC 4.7.2\]
config-settings:
use\_api = True
use\_api\_login = True
unicode test: ok


Version: unspecified
Severity: normal
See Also:
https://sourceforge.net/p/pywikipediabot/bugs/1579

Details

Reference
bz55152

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:23 AM
bzimport set Reference to bz55152.
bzimport added a subscriber: Unknown Object (????).

Change 111832 had a related patch set uploaded by Nullzero:
Make Recentchanges return all revisions

https://gerrit.wikimedia.org/r/111832

Change 111832 had a related patch set uploaded by Nullzero:
Make Recentchanges return all revisions

https://gerrit.wikimedia.org/r/111832

Change 116218 had a related patch set uploaded by Nullzero:
Make Recentchanges be able to return all revisions

https://gerrit.wikimedia.org/r/116218

Change 111832 abandoned by Nullzero:
Make Recentchanges return all revisions

Reason:
Can't rebase -- create a new one instead

https://gerrit.wikimedia.org/r/111832

Change 116218 merged by jenkins-bot:
Make Recentchanges be able to return all revisions

https://gerrit.wikimedia.org/r/116218