Page MenuHomePhabricator

Patch I submitted for djvutext.py was not applied correctly
Closed, InvalidPublic

Description

Originally from: http://sourceforge.net/p/pywikipediabot/bugs/1112/
Reported by: dischead
Created on: 2010-01-08 19:37:48
Subject: Patch I submitted for djvutext.py was not applied correctly
Original description:
In ID 2927811, I submitted a patch to djvutext.py so that it would call DjVuLibre's djvutxt binary with correct command-line options.

A change was checked into Subversion \(r7865\). However, this change was incorrect. It's possible that the edit was made by hand rather than applying the patch I provided.

The "--page" option to djvutxt must have a space instead of an equals sign between itself and the page number. If an equals sign is there, djvutxt will ignore the option and dump ALL text in the given DjVu file. This is likely to cause incorrect behavior in djvutext.py.

So all that's needed is to change the equals sign to a space. I'm attaching a new patch, but I think this can be done by hand. ;-\)

Thanks\!


Version: unspecified
Severity: normal
See Also:
https://sourceforge.net/p/pywikipediabot/bugs/1112

Details

Reference
bz55290

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:32 AM
bzimport set Reference to bz55290.
bzimport added a subscriber: Unknown Object (????).

Re-fix usage of DjVuLibre's djvutxt binary

Change 91868 had a related patch set uploaded by Ladsgroup:
a minor fix for djvutext.py

https://gerrit.wikimedia.org/r/91868

1- It's against the documentation: http://djvu.sourceforge.net/doc/man/djvutxt.html

2- I checked and It didn't work in your way but It worked when I used "=" (the old system.
http://fa.wikisource.org/wiki/%D8%A8%D8%B1%DA%AF%D9%87:Ladsgroup/1

So I close this bug as INVALID

Change 91868 abandoned by Ladsgroup:
a minor fix for djvutext.py

Reason:
You're right I checked it

https://gerrit.wikimedia.org/r/91868