Page MenuHomePhabricator
Create Task
Maniphest T57373

InlineHistory "marked as a duplicate" detection too eager
Closed, ResolvedPublic
Actions

Description

I've been reading bug 45051, caressing my ego, when I noticed…

Below bug 45051 comment 6, InlineHistory claims that MZMcBride marked a bug as a duplicate of that one. This is not true; Krinkle did that in comment 5, and MZMcBride only quoted the automatic comment.

The only explanation I see is that InlineHistory "marked as a duplicate" detection is too eager. It should only trigger when that comment is at the end of the comment, in a separate paragraph.

Version: unspecified
Severity: minor
See Also:
https://bugzilla.mozilla.org/show_bug.cgi?id=928387

Details

Reference
bz55373

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:37 AM
• bzimport added projects: Wikimedia-Bugzilla, Upstream.
• bzimport set Reference to bz55373.
matmarex created this task.Oct 6 2013, 6:23 PM
Aklapper added a comment.Oct 8 2013, 12:31 PM

Interesting. Probably should go upstream as I didn't change any code. Only slightly related ticket I could find was https://bugzilla.mozilla.org/show_bug.cgi?id=759768

Aklapper added a comment.Oct 18 2013, 2:22 PM

Upstreamed as https://bugzilla.mozilla.org/show_bug.cgi?id=928387

Aklapper added a comment.Oct 21 2013, 9:25 AM

I (or anybody) need to create a similar testcase (bug report) on http://boogs.wmflabs.org and then apply https://bug928387.bugzilla.mozilla.org/attachment.cgi?id=819545 on http://boogs.wmflabs.org to test if it fixes the issue.

gerritbot added a comment.Oct 23 2013, 9:59 AM

Change 91362 had a related patch set uploaded by Aklapper:
Fix InlineHistory's "marked as a duplicate" detection being too eager

https://gerrit.wikimedia.org/r/91362

gerritbot added a comment.Oct 25 2013, 5:21 PM

Change 91362 merged by Dzahn:
Fix InlineHistory's "marked as a duplicate" detection being too eager

https://gerrit.wikimedia.org/r/91362

Dzahn added a comment.Oct 25 2013, 5:22 PM

this has been deployed.

matmarex added a comment.Oct 25 2013, 5:50 PM

Thank you! The issue described in comment 0 is fixed now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL