Page MenuHomePhabricator
Create Task
Maniphest T57522

Option to delete image in imagecopy.py once it's been transferred
Closed, ResolvedPublic
Actions

Description

Pywikibot is a Python-based framework to write bots for MediaWiki (more information).

Once an image has been copied with imagecopy.py and a sysop account is configured for that wiki, we should provide an option to delete the image.

You need to add a new param in scripts/imagecopy.py. Then add at the end of the process, after the import on Wikimedia Commons, add a check that verifies if the new param was enabled and if the user has sysop rights, then delete the old picture.

You are expected to provide a patch in Wikimedia Gerrit. Documentation on Gerrit is available.

Details

Reference
bz55522
SubjectRepoBranchLines +/-
scripts/imagecopy.py: Add -delete optionpywikibot/coremaster+23 -8
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:20 AM
• bzimport added a project: Pywikibot-Scripts.
• bzimport set Reference to bz55522.
• bzimport added a subscriber: Unknown Object (????).
Legoktm created this task.Oct 9 2013, 6:16 PM
Legoktm added a comment.Oct 10 2014, 7:07 AM

Un-cookie licking

Aklapper added a project: Pywikibot-compat.Nov 27 2014, 4:01 PM
jayvdb moved this task from Backlog to Unported (still maintained) on the Pywikibot-compat board.Nov 30 2014, 1:42 PM
Ricordisamoa subscribed.Feb 25 2015, 5:57 PM
Aklapper lowered the priority of this task from Low to Lowest.Jun 5 2015, 1:41 PM
Aklapper subscribed.

Pywikibot has two versions: Compat and Core. This task was filed about the older version, called Pywikibot-compat, which is not under active development anymore. Hence I'm lowering the priority of this task to reflect the reality. Unfortunately, the Pywikibot team does not have the manpower to retest every single bug report / feature request against the (maintained) Pywikibot code base. Furthermore, the code base of Pywikibot-Compat has changed a lot compared to the code base of Pywikibot-Core so there is a chance that the problem described in this task might not exist anymore. Please help: Unfortunately manpower is limited and does not allow testing every single reported task again. If you have time and interest in Pywikibot, please upgrade to Pywikibot-Core and add a comment to this task if the problem in this task still happens in Pywikibot-Core (or directly edit the task by removing the Pywikibot-compat project and adding the Pywikibot project to this task). To learn more about Pywikibot and to get involved in its development, please check out https://www.mediawiki.org/wiki/Manual:Pywikibot/Development Thank you for your understanding.

Xqt added a project: Pywikibot.Sep 20 2015, 12:03 PM
Xqt subscribed.

Might become a core enhancement but declined for compat due to the deprecation.

Xqt removed a project: Pywikibot-compat.Sep 20 2015, 12:04 PM
Xqt set Security to None.
Framawiki raised the priority of this task from Lowest to Low.Nov 3 2017, 10:45 AM
Framawiki added projects: Google-Code-in-2017, Pywikibot-Commons.
Framawiki subscribed.

I purpose to mentor this task for Google-Code-in-2017. The big @Aklapper message is not to be taken into account, the script also exists for core.

You need to add a new param in scripts/imagecopy.py. Then add at the end of the process, after the import on Commons, add a check that verify if the new param was enabled and if the user has sysop rights, then delete the old picture.

matej_suchanek updated the task description. (Show Details)Nov 3 2017, 7:45 PM
Aklapper updated the task description. (Show Details)Nov 25 2017, 9:37 PM
Aklapper updated the task description. (Show Details)
Aklapper moved this task from Proposed tasks to Imported in GCI Site on the Google-Code-in-2017 board.Nov 25 2017, 9:39 PM

Imported as https://codein.withgoogle.com/tasks/5311794149064704/

gerritbot subscribed.Dec 10 2017, 8:38 AM

Change 396910 had a related patch set uploaded (by Rafidaslam; owner: rafid):
[pywikibot/core@master] scripts/imagecopy.py: Add -delete option

https://gerrit.wikimedia.org/r/396910

gerritbot added a project: Patch-For-Review.Dec 10 2017, 8:38 AM
rafidaslam subscribed.EditedDec 10 2017, 8:46 AM

Just made a patch for this on gerrit^, for running this script I had to make some modifications in the script (since some parts are not working in my machine). and a note, I haven't test it yet, since I don't have a sysop privilege in any wiki.

rafidaslam claimed this task.Dec 10 2017, 8:46 AM
gerritbot added a comment.Dec 12 2017, 2:50 PM

Change 396910 merged by jenkins-bot:
[pywikibot/core@master] scripts/imagecopy.py: Add -delete option

https://gerrit.wikimedia.org/r/396910

Dvorapa subscribed.Dec 12 2017, 9:56 PM

@rafidaslam You can ask for sysop rights for testing purposes on testwiki and in a few hours you will get them ;)

rafidaslam added a comment.Dec 13 2017, 11:48 AM

Sounds good!

Dvorapa added a comment.Dec 13 2017, 8:06 PM

(see https://test.wikipedia.org/wiki/Main_Page#Becoming_an_administrator)

rafidaslam added a comment.Dec 14 2017, 12:41 AM

Ok, just submitted my request https://test.wikipedia.org/wiki/Wikipedia:Requests/Permissions/Rafidaslam

Dvorapa added a comment.May 27 2018, 4:20 PM

@rafidaslam The request was not successful, not sure why. You can try these alternatives to test, but you have to configure a family using generate_family_file: https://test.wikipedia.org/wiki/Wikipedia:Requests/Tools

Dvorapa removed a project: Patch-For-Review.Jun 11 2018, 10:09 AM
Framawiki closed this task as Resolved.Sep 2 2018, 8:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL