Page MenuHomePhabricator

Give Bugzilla's "Save Changes" button some style.
Closed, DeclinedPublic

Description

Initial css (from mediawiki.ui.vector.css)

The native "Save Changes" button in the corner here on Bugzilla looks horrible (at least on my Browser+OS combo). Lets try applying some style (how about the new mw.ui buttons being used in Vector).


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz55536

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:21 AM
bzimport set Reference to bz55536.
bzimport added a subscriber: Unknown Object (MLST).

Button style without css (OSX + Firefox)

Attached:

Screen_Shot_2013-10-09_at_4.09.31_PM.png (115×344 px, 14 KB)

Button style with modified mw.ui css

Attached:

Screen_Shot_2013-10-09_at_4.10.31_PM.png (108×304 px, 14 KB)

Change 106864 had a related patch set uploaded by 01tonythomas:
Gave Bugzilla's "Save Changes" button style.

https://gerrit.wikimedia.org/r/106864

(Maybe my comment 3 towards the bug reporter was confusing for third parties, as it might have implied that I recommend and already support this change.)

So the proposed style can be seen e.g. for "Create another account" on https://en.wiktionary.org/w/index.php?title=Special:UserLogin&returnto=Wiktionary%3AMain+Page&type=signup but not for "Save" at the bottom of https://www.mediawiki.org/wiki/Special:Preferences?useskin=vector which is semantically close enough to Bugzilla's "Save Changes" button.

Hence I am not convinced why we should introduce such style inconsistency and make buttons look that much different from all other UI elements in our Bugzilla, but I welcome good arguments. :)

Technically: For approaches to make Bugzilla look more like MediaWiki's Vector skin, editing the CSS file /skins/contrib/Wikimedia/vector.css feels like a better fit.

(In reply to Andre Klapper from comment #5)

why should we introduce such style inconsistency and make buttons look
that much different from all other UI elements in our Bugzilla?

Daniel: ping?

(In reply to Andre Klapper from comment #6)

(In reply to Andre Klapper from comment #5)

why should we introduce such style inconsistency and make buttons look
that much different from all other UI elements in our Bugzilla?

Daniel: ping?

If that's an issue how about widening the scope of the bug? An interested party could try to restyle all the other form inputs to match those vector styles being created.

Alright, however I wonder how to keep Bugzilla CSS and MediaWiki UI in sync in the long run...

Wikimedia has migrated from Bugzilla to Phabricator. Learn more about it here: https://www.mediawiki.org/wiki/Phabricator/versus_Bugzilla - This task does not make sense anymore in the concept of Phabricator, hence closing as declined.