Upload test for file with no extension failing under hhvm: FILETYPE_BADTYPE instead of FILETYPE_MISSING.
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	• demon
	Oct 10 2013, 1:45 AM

Description

We're getting FILETYPE_BADTYPE when we should be getting FILETYPE_MISSING.

$ hhvm phpunit.php includes/upload/UploadBaseTest.php
PHPUnit 3.7.23 by Sebastian Bergmann.

Configuration read from /www/mediawiki/core/tests/phpunit/suite.xml

.....F......

Time: 194 ms, Memory: 11.67Mb

There was 1 failure:

UploadBaseTest::testTitleValidation with data set #5 ('A', NULL, 8, 'upload title without extension')

upload title without extension code
Failed asserting that 9 matches expected 8.

/www/mediawiki/core/tests/phpunit/includes/upload/UploadBaseTest.php:38
/www/mediawiki/core/tests/phpunit/MediaWikiTestCase.php:116
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:80
/www/mediawiki/core/tests/phpunit/MediaWikiPHPUnitCommand.php:64

Version: 1.22.0
Severity: normal

Details

Reference: bz55543

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM

• bzimport added a project: MediaWiki-Uploading.

• bzimport set Reference to bz55543.

• bzimport added a subscriber: Unknown Object (MLST).

• demon created this task.Oct 10 2013, 1:45 AM

[Using keyword instead of tracking bug for HipHop issues as requested in bug 40926 comment 5. Filter bugmail on this message.]

Works with hhvm 3.

• Gilles added a project: Multimedia.Dec 4 2014, 10:20 AM

• Gilles raised the priority of this task from Medium to Unbreak Now!.Dec 4 2014, 10:24 AM

• Gilles moved this task from Untriaged to Done on the Multimedia board.

• Gilles lowered the priority of this task from Unbreak Now! to Medium.Dec 4 2014, 11:23 AM

Upload test for file with no extension failing under hhvm: FILETYPE_BADTYPE instead of FILETYPE_MISSING.Closed, DeclinedPublicActions

Description

Details

Event Timeline

Upload test for file with no extension failing under hhvm: FILETYPE_BADTYPE instead of FILETYPE_MISSING.
Closed, DeclinedPublic
Actions