Page MenuHomePhabricator

Commons app crashes on malformed server API response
Closed, DeclinedPublic

Description

USER_COMMENT=startup
ANDROID_VERSION=4.3
APP_VERSION_NAME=1.0beta10
BRAND=google
PHONE_MODEL=Nexus 4
CUSTOM_DATA=
STACK_TRACE=java.io.IOError: org.xml.sax.SAXParseException: Unexpected token (position:TEXT This version of ...@3:1 in java.io.InputStreamReader@41e708d8)
at org.mediawiki.api.ApiResult.fromRequestBuilder(ApiResult.java:58)
at org.mediawiki.api.MWApi.makeRequest(MWApi.java:186)
at org.mediawiki.api.MWApi.access$000(MWApi.java:30)
at org.mediawiki.api.MWApi$RequestBuilder.get(MWApi.java:46)
at org.wikimedia.commons.contributions.ContributionsSyncAdapter.onPerformSync(ContributionsSyncAdapter.java:72)
at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:254)
Caused by: org.xml.sax.SAXParseException: Unexpected token (position:TEXT This version of ...@3:1 in java.io.InputStreamReader@41e708d8)
at org.apache.harmony.xml.parsers.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:146)
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:107)
at org.mediawiki.api.ApiResult.fromRequestBuilder(ApiResult.java:44)
... 5 more
org.xml.sax.SAXParseException: Unexpected token (position:TEXT This version of ...@3:1 in java.io.InputStreamReader@41e708d8)
at org.apache.harmony.xml.parsers.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:146)
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:107)
at org.mediawiki.api.ApiResult.fromRequestBuilder(ApiResult.java:44)
at org.mediawiki.api.MWApi.makeRequest(MWApi.java:186)
at org.mediawiki.api.MWApi.access$000(MWApi.java:30)
at org.mediawiki.api.MWApi$RequestBuilder.get(MWApi.java:46)
at org.wikimedia.commons.contributions.ContributionsSyncAdapter.onPerformSync(ContributionsSyncAdapter.java:72)
at android.content.AbstractThreadedSyncAdapter$SyncThread.run(AbstractThreadedSyncAdapter.java:254)


Version: unspecified
Severity: critical

Details

Reference
bz55576

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:24 AM
bzimport set Reference to bz55576.
bzimport added a subscriber: Unknown Object (MLST).

Looks like a debug build since it is at beta10. Install from market?

So this turns out to be due to a bug in MobileFrontend throwing errors from the API, and would affect the previous as well as the current version of the app.

I'm updating the bug summary to "Commons app crashes on malformed server API response".

Some more user-friendly error message should probably show up here, or it should do a graceful retry or something.

As the Mobile Apps Team is focussing on the new, native Wikipedia app, the Commons app is no longer being maintained by the Wikimedia Foundation. I am WONTFIXing all open Commons app bugs to reflect that we will not be spending time fixing them.

For the full story, see this thread on mobile-l: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/thread.html#7974