Page MenuHomePhabricator

Generate user config files at runtime, not install time
Closed, ResolvedPublic

Description

Author: yardenack

Description:
I'm packaging pywikibot for Arch Linux here: https://aur.archlinux.org/packages/python2-pywikibot-git/

Packing software for distribution means that install scripts might be run by a different person than the user. Install scripts are not the place for user config, and it's also bad practice to force ANY interactive configs at that stage.

Please don't run generate_user_files.py from setup.py. Find some way to do this at runtime.

Or, ideally, to behave sanely with no configs at all.

At the moment we are just providing a sample config for users to edit, and doing: sed -i /generate_user_files.py/Id setup.py


Version: core-(2.0)
Severity: major
OS: Linux

Details

Reference
bz55583

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:25 AM
bzimport set Reference to bz55583.
bzimport added a subscriber: Unknown Object (????).

This also blocking packaging for pypi as well.

Change 101662 had a related patch set uploaded by Merlijn van Deen:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662

yar, does this solve the issue on your end? Rewriting the user-config stuff to behave more sanely (which includes not requiring a user-config to begin with) is a longer-term project.

Change 101662 merged by jenkins-bot:
(bug 55583) Do not create user-config if stdin is not a tty

https://gerrit.wikimedia.org/r/101662

yardenack wrote:

This works, thanks!