Page MenuHomePhabricator

Thanks button not styled
Closed, ResolvedPublic

Description

Visit https://m.mediawiki.org/wiki/Special:MobileDiff/797556?debug=true
the Thanks button is not correctly styled here.
Eek.
Can replicate on master.


Version: unspecified
Severity: normal

Details

Reference
bz55596

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:26 AM
bzimport set Reference to bz55596.
bzimport added a subscriber: Unknown Object (MLST).

In JavaScript console:
Exception thrown by mobile.notifications.overlay: Template not found: overlays/notifications

False alarm - no longer get that exception... but still not seeing the correct styling.

(On a side note mobilediff.less should make better use of the .vertical-gradient mixin and nesting e.g. use &:active etc.. )

The css expects a .content wrapper but that no longer exists.

Change 89122 had a related patch set uploaded by Kaldari:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/89122

Change 89122 merged by jenkins-bot:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/89122

Change 90053 had a related patch set uploaded by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90053

Change 90054 had a related patch set uploaded by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90054

Change 90053 merged by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90053

Change 90054 merged by MaxSem:
Fixing Thank button styling

https://gerrit.wikimedia.org/r/90054