Fix missing and misplaced dependencies
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Mattflaschen-WMF
	Oct 11 2013, 11:37 AM

Description

In addition to bug 55550, there seem to be at least a couple other places where there are unneeded dependencies, or missing ones.

mw.TimedText (in TimedMediaHandler) depends on jquery.ui.dialog, but does not use it directly. This should be removed.
ext.tmh.transcodetable - No listed dependencies at all currently, but uses both mw.addDialog (from mw.MwEmbedSupport) and jquery.ui.dialog.

Version: master
Severity: normal

	Subject	Repo	Branch	Lines +/-
	TimedText: Remove unneeded dependency on jquery.ui.dialog	mediawiki/extensions/TimedMediaHandler	master	+0 -1

Status	Assigned	Task
Resolved	TheDJ	T57615 Fix missing and misplaced dependencies
Resolved	None	T57550 Reduce amount of code loaded in MwEmbedSupport and TimedMediaHandler startup and BeforePageDisplay
Resolved	None	T60086 mw.MwEmbedSupport.style should only load on the pages that need it

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:27 AM

• bzimport set Reference to bz55615.

Krinkle set Security to None.

Change 198525 had a related patch set uploaded (by TheDJ):
TimedText: Remove unneeded dependency on jquery.ui.dialog

This patch https://gerrit.wikimedia.org/r/198525 fixes the mw.TimedText dependencies.
The transcodetable module dependency has already been fixed with: https://gerrit.wikimedia.org/r/173538

Change 198525 merged by jenkins-bot:
TimedText: Remove unneeded dependency on jquery.ui.dialog

TheDJ closed this task as Resolved.Apr 14 2015, 12:03 PM

TheDJ moved this task from Doing to Done on the TimedMediaHandler board.