Page MenuHomePhabricator

Cite: Module "ext.cite" should not be loaded on pages without <ref> (e.g. Special pages)
Closed, ResolvedPublic

Description

According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite" ResourceLoader module. This seems to be a global module, but it doesn't need to be loaded on any Special page besides Special:Cite, I imagine.

I'm not sure if this is a bug. And if it is a bug, I'm not sure if it should be filed against the "Cite" MediaWiki extension or against MediaWiki core JavaScript.


Version: unspecified
Severity: normal

Details

Reference
bz55684

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:32 AM
bzimport set Reference to bz55684.
bzimport added a subscriber: Unknown Object (MLST).

(In reply to comment #0)

I'm not sure if this is a bug. And if it is a bug, I'm not sure if it should
be
filed against the "Cite" MediaWiki extension or against MediaWiki core
JavaScript.

According to the source code (https://github.com/wikimedia/mediawiki-extensions-Cite/blob/master/Cite.php#L72), it's added by the extension.

(In reply to comment #0)

According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite"
ResourceLoader module. This seems to be a global module, but it doesn't need
to
be loaded on any Special page besides Special:Cite, I imagine.

Technically any Special page might have <ref></ref> tags due to local modifications of system messages, so in those cases the RL module would be needed.

(In reply to comment #2)

(In reply to comment #0)

According to mw.loader.inspect(), [[Special:BlankPage]] loads the "ext.cite"
ResourceLoader module. This seems to be a global module, but it doesn't need
to
be loaded on any Special page besides Special:Cite, I imagine.

Technically any Special page might have <ref></ref> tags due to local
modifications of system messages, so in those cases the RL module would be
needed.

In that case the parser hook can call $parserOutput->addModules(). The Cite extension is still using the classic way of adding resources through wgHooks['BeforePageDisplay'] instead of doing it the new way through contextual addModules when it actually needs to.

Change 89617 had a related patch set uploaded by Legoktm:
Only load RL modules when a <ref> tag is being used

https://gerrit.wikimedia.org/r/89617

Change 89617 merged by jenkins-bot:
Only load RL modules when a <ref> tag is being used

https://gerrit.wikimedia.org/r/89617