Page MenuHomePhabricator

Create a Bootstrap 3 compliant version of Chameleon that works with the latest stable version of MW
Closed, DeclinedPublic

Description

Currently, Chameleon skin does support Bootstrap 3, but only with MW 1.22alpha (because of its dependencies). Please consider creating a version of the skin that works with 1.21 stable.


Version: unspecified
Severity: enhancement

Details

Reference
bz55688

Event Timeline

bzimport raised the priority of this task from to Lowest.Nov 22 2014, 2:32 AM
bzimport added a project: Chameleon.
bzimport set Reference to bz55688.

Does it work, if you install the Less extension? If not, what is the error?

PHP Fatal error: Call to undefined method skins\\chameleon\\ChameleonTemplate::get() in /var/www/wiki2/skins/chameleon/components/MainContent.php on line 49

I get that even with the oldest revision that supports Bootstrap 3 (8e757951fba2a00f29fc9603d5ac191ddb95caab).

Note that part of the problem is that Bootstrap extension v 0.1 is only compatible with MW 1.22+ so I had to install use revision 4d32f1440be9c3fbaac5da3f57907c6bcb0c629a of that extension instead.

The problem is due to the addition of function get() to the includes/SkinTemplate.php in 1.22 and reliance of Chameleon on this function.

It would be better to use the latest version of Bootstrap and comment out the version check at the beginning of Bootstrap.php.

The get method is new in 1.22. To take care of it replace every $skintemplate->get( 'something' ) in MainContent.php by $skintemplate->data[ 'something' ].

With that, I get:

PHP Fatal error: Call to undefined method ResourceLoader::getLessCompiler()

Replace

$compiler = ResourceLoader::getLessCompiler();

in ResourceLoaderBootstrapModule by

$compiler = new \lessc();

Doesn't help much. Now I get this error (and many more like this one):

File does not exist: /var/www/wiki2/responsive-utilities

Ok, then I give up for now. I had hoped it would be as easy as using the lessphp compiler of the Less extension instead of the built-in one in 1.22.

Exactly. That is why I opened this bug. It would be great if you could create a tagged version of these extensions and skin, that works with the latest stable release of MW.

Closing as obsolete. 1.22 is released as stable since 2013-12-06.