Page MenuHomePhabricator

code documentation around wgUseFileCache
Closed, ResolvedPublic

Description

I'm not sure if code comments are part of "Documentation", but I didn't see a more likely category.

from includes/DefaultSettings.php :

/**

  • This will cache static pages for non-logged-in users to reduce
  • database traffic on public sites.
  • Must set $wgShowIPinHeader = false
  • ResourceLoader requests to default language and skins are cached
  • as well as single module requests. */

$wgUseFileCache = false;

The comment about "Must set wgShowIPinHeader = false" has not been true for some time, as it is done automatically when File Cache is used (since 1.15 according to HISTORY).


Version: 1.22.0
Severity: minor

Details

Reference
bz55723

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:35 AM
bzimport set Reference to bz55723.
bzimport added a subscriber: Unknown Object (MLST).

Change 96691 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96691

Change 96691 abandoned by Persia:
Update comment in DefaultSettings for bug 17180

Reason:
This is the wrong branch name, which is likely to be confusing to reviewers.

https://gerrit.wikimedia.org/r/96691

Change 96692 had a related patch set uploaded by Persia:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692

Change 96692 merged by jenkins-bot:
Update comment in DefaultSettings for bug 17180

https://gerrit.wikimedia.org/r/96692

Assuming this bug is FIXED as per comment 4.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.