The fact the function name is not camel case is confusing (the l is actually lowercase).
Might I suggest we make it a more meaningful name e.g. mw.util.getUrl and support this name in a legacy JavaScript file?
Version: 1.19
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz55764
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| mediawiki.util: Remove deprecated wikiGetlink() | mediawiki/core | master | +3 -8 |
Event Timeline
Comment Actions
True. Let's mw.log.deprecate() it and use a saner name (getUrl looks okay, getPageUrl might be okay too).
Comment Actions
Change 90569 had a related patch set uploaded by Bartosz Dziewoński:
Rename mw.util.wikiGetlink to getUrl
Comment Actions
What about changing also:
- mw.util.rawurlencode -> mw.util.rawUrlEncode
- mw.util.wikiUrlencode -> mw.util.wikiUrlEncode
?
Comment Actions
(In reply to comment #4)
- mw.util.rawurlencode -> mw.util.rawUrlEncode
- mw.util.wikiUrlencode -> mw.util.wikiUrlEncode
rawurlencode() and urlencode() are functions in PHP, and these are PHP-isms.
We might want to rename them to something more JavaScriptey (related function in JS is called encodeURIComponent()).
Comment Actions
Change 94270 had a related patch set uploaded by Krinkle:
Rename mw.util.wikiGetlink to getUrl
Comment Actions
Change 94271 had a related patch set uploaded by Krinkle:
Rename mw.util.wikiGetlink to getUrl
Comment Actions
Change 95474 had a related patch set uploaded by Catrope:
Rename mw.util.wikiGetlink to getUrl
Comment Actions
Change 429993 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] mediawiki.util: Remove deprecated wikiGetlink()
Comment Actions
Change 429993 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.util: Remove deprecated wikiGetlink()