VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected link
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Catrope
	Oct 17 2013, 2:11 PM

Description

Create a page with two links that point to the same page or URL, and a link that points to a different page/URL
Inspect one of the twin links with the link inspector. The suggestions dropdown is displayed (*)
Inspect the other twin link. The suggestions dropdown isn't displayed
Inspect the third link. The suggestions dropdown is displayed again
Inspect the link from #3. The suggestions dropdown is displayed now
Close the inspector, the inspect the same link again. The suggestions dropdown isn't displayed

This is because the value in the text input doesn't change when you inspect the same link twice or inspect two links with the same target. The link inspector should consistently display the dropdown when it opens.

(*) I would argue that we should /not/ display the dropdown in this case, IMO it's useless and confusing. But the point of this bug is that we should have consistent behavior.

Version: unspecified
Severity: normal

Details

Reference: bz55839

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM

• bzimport added projects: VE-deploy-2014-06-12, VisualEditor-EditingTools.

• bzimport set Reference to bz55839.

Catrope created this task.Oct 17 2013, 2:11 PM

Another issue which might be related with this follows the following steps:

1.Create any link with a target URL
2.Inspect another link of the page with a different target URL
3.Now point to a blank space and press ctrl+k or command+k

Observed Result:

The link inspector appears in a swipe way from right to left and the content of the link inspector is the suggestion of the link that was created in step 1.

I am not sure how the expected result should be in this case when a user press command+k in an empty space.I think there should not be any pre-set suggestion for that.

In step 3, if i click on the link icon from the tool bar instead of pressing ctrl+k or command+k , then the link inspector opens up at the end of the text created in step 1.

See the screenshots for more reference.

Created attachment 13668
Showing suggestions in blank space

Attached:

Screen_Shot_2013-11-01_at_12.34.16_PM.png (354×782 px, 39 KB)

Created attachment 13669
Showing suggestions in blank space

Attached:

Screen_Shot_2013-11-01_at_4.45.04_PM.png (175×322 px, 14 KB)

Created attachment 13670
showing wrong suggestions at the end of the previously selected link

Attached:

Screen_Shot_2013-11-01_at_4.43.45_PM.png (227×382 px, 16 KB)

This is now fixed, but anyway masked by the expedient of not opening the suggestion box until the user changes something.

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:03 AM

Jdforrester-WMF added a project: VisualEditor-MediaWiki-Links.Jan 27 2015, 11:52 PM

Jdforrester-WMF removed a parent task: T50789: VisualEditor: Improvements and behaviour changes to the link input widget (tracking).Sep 10 2015, 6:56 PM

Jdforrester-WMF added a project: VisualEditor pre-2015 work.Sep 10 2015, 7:08 PM

Jdforrester-WMF set Security to None.

	F11975: Screen_Shot_2013-11-01_at_4.43.45_PM.png
	Nov 22 2014, 2:13 AM

	F11974: Screen_Shot_2013-11-01_at_4.45.04_PM.png
	Nov 22 2014, 2:13 AM

	F11973: Screen_Shot_2013-11-01_at_12.34.16_PM.png
	Nov 22 2014, 2:13 AM

VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected linkClosed, ResolvedPublicActions

Description

Details

Event Timeline

VisualEditor: Link inspector does not show suggestions dropdown on open if link target is the same as the target of the most recently inspected link
Closed, ResolvedPublic
Actions