Page MenuHomePhabricator

Interwiki tooltip: " in title is escaped
Closed, ResolvedPublic

Description

If an interwiki tooltip contains a " in the target page name, the " is escaped:

Current interwiki tooltip for Polnish:
12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)"Sturer Emil" – Polnisch

Expected output:
12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)"Sturer Emil" – Polnisch

see
[[pl:12.8 cm Selbstfahrlafette auf VK3001(H) (Panzerselbstfahrlafette V)"Sturer Emil"]]


Version: 1.22.0
Severity: normal
URL: https://de.wikipedia.org/wiki/Selbstfahrlafette_L/61
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55865

Details

Reference
bz55847

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:13 AM
bzimport set Reference to bz55847.

This also happens for & ([[Procter & Gamble]], e.g. Procter & Gamble – German) and ' ([[America's Cup]], e.g. America's Cup – Old English)

I guess the message shouldn't be ->escaped() in SkinTemplate::getLanguages.

Change 94602 had a related patch set uploaded by Umherirrender:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94602

Change 94602 merged by jenkins-bot:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94602

Please backport to 1.22rc1 to allow backport of bug 56129 . Thanks

Change 94942 had a related patch set uploaded by Bartosz Dziewoński:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94942

Done. Note that 1.22 is not a stable version yet, so the flag currently refers to 1.21 and older versions; reopen and set milestone to 1.22.0 for backporting there.

(This would be way easier if the flag wasn't so stupidly named.)

Change 94942 merged by Bartosz Dziewoński:
Do not escape title attribute twice for tooltip-iwiki

https://gerrit.wikimedia.org/r/94942

  • Bug 57309 has been marked as a duplicate of this bug. ***