Page MenuHomePhabricator

Make plugin work with the long-term supported version (currently 1_19)
Closed, DeclinedPublic

Description

Author: jcrowe

Description:
We would like to use this plugin for our MediaWWiki sites at mozilla, however we are on the LTS version which is currently 1_19. It would be awesome if this plugin could work with that version.

I installed the plugin on a 1_19 vanilla install and it does nothing. Well I should say that I get the persona link, when I click it I get the normal Persona popup which I can click through and I am returned to the site. When I am returned to the site I am not logged in. I have a user on the wiki which has my Persona email associated with it and can log in with this user in the normal fashion.

I also spun up a 1_21 vanilla install and tested the plugin there but this simply causes the pages to endlesly reload. Perhaps This issue is unrelated and I can spin off a new bug for that issue if you wish.

Please let me know if I can provide any further details or if you will be able to make this work with the LTS version.

Thank You
Jason


Version: REL1_19-branch
Severity: major

Details

Reference
bz55975

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:22 AM
bzimport set Reference to bz55975.

So it seems this is actually a number of bugs combined into one:

  • Mozilla changed their login endpoint and CA certificate.
  • The Extension:Persona JavaScript was not calling navigator.id.logout() upon unsuccessful authentication
  • There was a massive Javascript API architecture change between version 1.19 and 1.20 of MediaWiki

I'm hoping to fix all of these issues in one go. I'm about to upload a patch that makes the extension work on 1.19 and 1.20. I'm not sure if it works on 1.21 because there was a bug introduced that I'm fixing separately.

Once that patch is code reviewed and merged the extension should work for you. Thanks for your patience.

Change 91417 had a related patch set uploaded by Parent5446:
Fix extension functionality and backwards compatibility

https://gerrit.wikimedia.org/r/91417

Change 91417 merged by Parent5446:
Fix extension functionality and backwards compatibility

https://gerrit.wikimedia.org/r/91417

OK, the patch was just submitted, and the extension should now work on MediaWiki 1.19 and later. And a number of other bugs were fixed as well.

Unfortunately ResourceLoader can change how it does things. Reopened pending the fix of bug 97478.

jcrowe wrote:

Hi,

I apologize for the delay on this. I finally got back to testing and have an issue. I am happy to open a new bug if you think it is appropriate but thought I would start by updating here.

To start with things are now working with MW version > REL1_21 and either the REL1_21 or master branch of this extension.

The issue with MW REL1_19 still exists. That issue being that I do not get the Persona popup when clicking the login URL on the page top or when clicking the Persona button on the login page. I have tested this with MW REL1_19 & REL1_20. Also I tested with the Persona extension on branch REL1_20, REL1_21, and master. I had the same experience with each. (Note that they all work on MW > REL1_21). Additionally I tested with both Firefox and Chrome just in case.

I do not see any REL1_19 branch with this extension but I am guessing form your comments that the REL1_20 branch should work.

Please let me know if I can provide any additional information that you thing might help.

Thanks

No problem. And sorry for the trouble. I'll try testing it out again and see why it's not working. My goal is to have the master branch of my extension be backwards compatible with 1.19, so ther won't be a REL1_19 branch.

Change 105242 had a related patch set uploaded by Parent5446:
More 1.19 backwards compatibility fixes

https://gerrit.wikimedia.org/r/105242

Hey, so the above patch should finally resolve everything. It works on my dev environment with 1.19.9 and with master. If you could just check it out and see if it works for you before I merge it, that'd be great.

jcrowe wrote:

After installing this patch version I can now login with Persona. This is awesome. Once this is merged in I will go about testing it on the staging environment, however I do not suspect any issues there.

Thanks for all your help with this issue .

Change 105242 merged by Parent5446:
More 1.19 backwards compatibility fixes

https://gerrit.wikimedia.org/r/105242

Thanks! If there are any other problems just let me know.

jcrowe wrote:

Hi,

I pulled from HEAD and the extension is working as it did. I have found another issue however.

I am running this behind a load balancer and have an issue where the login link in the page corner simply redirects and does not log the user in. If I use the button on the login page it works and thence the login link in the corner works. I am guessing this has something do do with how the session is created but did not dig into it.

I set the '$wgPersonaLoginAnywhere = false;' in my LocalSettings file and this removed the link from the top corner.

The issue is that now the login button on the login page does not do anything.

Thanks again for the help and let me know if you want this issue in a new bug.

jcrowe wrote:

Hi, just checking to see if there is any traction on this issue?

Thanks

@Parent5446 : Still working on this (as you are assignee)?
Still high priority, now that 1.19 will face its end-of-life in one month? Still an issue with 1.23 LTS?

@Parent5446 : Still working on this (as you are assignee)?
Still high priority and still an issue with 1.23 LTS?

Aklapper lowered the priority of this task from High to Medium.Jun 16 2015, 2:08 PM

Not working on it at the moment, so I'll un-assign. Not sure if it's still an issue, but will try and find time to check later.

hashar subscribed.

From T155291:

Closing as the Persona service has been shut down.

From Mozilla:

Persona is no longer actively developed by Mozilla. Mozilla kept operational and security support of the persona.org service until November 2016.
On November 30th, 2016, the persona.org services were shut down.

See also: