Page MenuHomePhabricator

Have the option of cloning things from github
Closed, DeclinedPublic

Description

Since Gerrit is all the time rather very slow for me and also has intermittent failures - clones just hang forever, making provision hang forever.

Details

Reference
bz56046

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:27 AM
bzimport set Reference to bz56046.
bzimport added a subscriber: Unknown Object (MLST).

Hacky patch that clones from github directly.

diff --git a/puppet/modules/git/manifests/clone.pp b/puppet/modules/git/manifests/clone.pp
index 5d6ab62..d1edaa9 100644

  • a/puppet/modules/git/manifests/clone.pp

+++ b/puppet/modules/git/manifests/clone.pp
@@ -24,7 +24,7 @@ define git::clone($directory, $remote=undef) {

include git
 
$url = $remote ? {
  • undef => sprintf($git::urlformat, $title),

+ undef => sprintf($git::urlformat, regsubst($title, '/', '-', 'G')),

    default => $remote,
}

diff --git a/puppet/modules/git/manifests/init.pp b/puppet/modules/git/manifests/init.pp
index c36ea4b..f5949c8 100644

  • a/puppet/modules/git/manifests/init.pp

+++ b/puppet/modules/git/manifests/init.pp
@@ -19,7 +19,7 @@

+ $urlformat = 'https://github.com/wikimedia/%s.git',
) {

package { 'git':
    ensure  => latest,

Change 157695 had a related patch set uploaded by BryanDavis:
Support Github URLs

https://gerrit.wikimedia.org/r/157695

Bulk unassigning bugs from Ori.

Yuvi, are you still interested in this feature? If so review of the patch and help advocating for the feature would be appreciated. If not I'll probably just abandon the patch I made.

bd808 triaged this task as Low priority.Dec 2 2014, 1:47 AM
bd808 changed the task status from Open to Stalled.Dec 30 2014, 3:05 AM
bd808 lowered the priority of this task from Low to Lowest.
This comment was removed by Aklapper.
Aklapper changed the task status from Stalled to Open.Nov 1 2020, 8:41 PM

The previous comments don't explain who or what (task?) exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence resetting task status, as tasks should not be stalled (and then potentially forgotten) for years for unclear reasons.

(Smallprint, as general orientation for task management:
If you wanted to express that nobody is currently working on this task, then the assignee should be removed and/or priority could be lowered instead.
If work on this task is blocked by another task, then that other task should be added via Edit Related Tasks...Edit Subtasks.
If this task is stalled on an upstream project, then the Upstream tag should be added.
If this task requires info from the task reporter, then there should be instructions which info is needed.
If this task needs retesting, then the TestMe tag should be added.
If this task is out of scope and nobody should ever work on this, or nobody else managed to reproduce the situation described here, then it should have the "Declined" status.
If the task is valid but should not appear on some team's workboard, then the team project tag should be removed while the task has another active project tag.)