Page MenuHomePhabricator
Create Task
Maniphest T58090

Do not change targets to javascript:void(0); on JavaScript load for various "edit" links
Closed, ResolvedPublic
Actions

Description

Instead, call event.preventDefault() on their onclick event.

Otherwise, with JavaScript loaded, midclicking the link (= open a new tab) creates a new empty page at javascript:void(0);.

Version: master
Severity: normal

Details

Reference
bz56090

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT58090 Do not change targets to javascript:void(0); on JavaScript load for various "edit" links
 InvalidNoneT56098 [Epic][UI] Front-end performance: Improve loading time of items
 ResolvedNoneT59746 Allow Entity pages to be stored in the ParserCache
 ResolvedNoneT60342 Inject the term box into cached page content
 ResolvedNoneT60344 Consistently use ParserOptions::getUserLang for generating entity pages
 ResolvedNoneT63242 Don't immediately load DOM only needed for editing
 ResolvedadrianheineT63739 Expert DOM is re-built several times on page load
 ResolvedNoneT58903 Wikibase\EntityView::getBasicEntityInfo must not load full data for all referenced entities.
 ResolvedNoneT63850 [UI] Remove dedicated event system of toolbar controller
 ResolvedNoneT59051 Optimize frontend template engine
 InvalidNoneT62341 [Task] Load widgets on demand
 ResolvedNoneT58259 jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpert
 ResolvedNoneT58263 Implement "ApiBasedValueFormatter" in the fashion of "ApiBasedValueParser"
 ResolvedNoneT58261 Implementation of basic value formatters in JavaScript
 ResolvedNoneT58765 create an api module for formatting data values
 ResolvedNoneT59014 Create a FormatValue API module for formatting data values
 ResolvedNoneT62342 [UI] Lightweight toolbars to initialize full toolbars
 ResolvedthiemowmdeT62536 review default gadgets on wikidata.org for performance improvements
 ResolvedNoneT64527 Reuse existing DOM on page initialization
 DeclinedNoneT118968 [Task] Investigate if removing of events improves loading times
 ResolvedthiemowmdeT119077 [Task] Remove template comments when rendering template
 DeclinedLydia_PintscherT119078 [Task] Move wbentity JSON to the end of the HTML
 DeclinedNoneT119079 [Task] Add another item to browsertest that measures performance
 InvalidNoneT78149 [Task] Prevent events from bubbling up the whole DOM unnecessarily
ResolvedthiemowmdeT121781 [Task] Pass known visibility state from statementview to toggler
 InvalidNoneT123233 [Task] Reduce ResourceLoader modules
 DeclinedNoneT124783 [Task] Investigate how to improve loading time of individual widgets
 OpenNoneT170245 Skip loading the property if the datatype has already been provided
 OpenNoneT124784 [Task] Make the JavaScript data model immutable
 ResolvedadrianheineT125503 [Story] Reduce initialization time of Statementview
 ResolvedadrianheineT125502 [Task] Investigate time spent for initialization of individual widgets
 ResolvedadrianheineT125642 [Task] Remove slow $().closest call from snakview
 ResolvedNoneT125643 [Task] Remove useless drawSnakTypeSelector call in snakview::_create
 ResolvedadrianheineT127316 [Bug] Can not save new quantity statement
 InvalidNoneT125658 [Story] Performance stats
 Declined• JonasT126609 [Task] Display performance statistic notification
 ResolvedNoneT127067 [Story] Reduce initialisation time of SiteLinks
 ResolvedadrianheineT127305 [Task] Change ellipsis from JS to CSS
 ResolvedadrianheineT127816 [Task] Render SiteLink count server side
 InvalidthiemowmdeT124786 [Task] Widgets should delegate isInitialValue calls as far as possible
 ResolvedadrianheineT114877 [Bug] DOM does not match configured languages
 ResolvedthiemowmdeT85004 Use CSS instead of jQuery for wb-claim-name position animation
 OpenNoneT100132 Load edit modules only when clicked on edit
 OpenNoneT52306 Provide info about referenced entities to UI in an efficient way
 ResolvedLadsgroupT85499 wbEntity shouldn't be served on every page load
 ResolvedLea_Lacroix_WMDET169770 Announce wikibase.entityPage.entityLoaded hook
 ResolvedLucas_Werkmeister_WMDET169771 Add deprecation warning to wbEntity
 ResolvedLucas_Werkmeister_WMDET179699 Stop using wbEntity from mw.config in entityViewInit
 Resolvedmatej_suchanekT169772 Make edit requests on top 5 gadgets using wbEntity
 ResolvedLea_Lacroix_WMDET169775 Declare Wikibase JavaScript hooks stable
 DeclinedNoneT229221 Reduce usages of wikibase.entityPage.entityLoaded hook in frontend code

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:30 AM
• bzimport added projects: MediaWiki-extensions-WikibaseRepository, JavaScript.
• bzimport set Reference to bz56090.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Oct 24 2013, 10:35 AM
Yair_rand added a comment.Feb 12 2014, 6:08 AM

As far as I can tell, the targets aren't actually changed. Instead, every single edit link on the page is actually removed/deleted. ($( 'td.wb-editsection' ).empty(); $( 'span.wb-editsection, div.wb-editsection' ).remove(); in wikibase.ui.entityViewInit.js) New ones, frequently hundreds of them, are built from scratch later on, with the target as javascript:void(0). That's probably awful for performance.

Lydia_Pintscher added a project: Wikidata.Dec 1 2014, 3:00 PM
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
Lydia_Pintscher removed a subscriber: Unknown Object (MLST).
He7d3r updated the task description. (Show Details)Dec 1 2014, 3:03 PM
He7d3r added a project: good first task.
He7d3r set Security to None.
Lydia_Pintscher moved this task from incoming to needs discussion or investigation on the Wikidata board.Dec 28 2014, 3:38 PM
Tobi_WMDE_SW subscribed.Jan 20 2015, 9:55 AM

https://github.com/wmde/ValueView/pull/148

Tobi_WMDE_SW added a project: Patch-For-Review.Jan 20 2015, 9:56 AM
Lydia_Pintscher moved this task from needs discussion or investigation to ready to go on the Wikidata board.Jan 20 2015, 11:57 AM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-01-08§.Jan 20 2015, 12:48 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-01-08§ board.
Tobi_WMDE_SW added a project: § Wikidata-Sprint-2015-01-21.Jan 21 2015, 1:06 PM
adrianheine added a comment.Jan 21 2015, 1:48 PM

While the linked change is an improvement, I would prefer to [use buttons](http://stackoverflow.com/a/12642009/55965) for elements which don't link somewhere (aka don't work without JS).

Tobi_WMDE_SW moved this task from Backlog to Review on the § Wikidata-Sprint-2015-01-21 board.Jan 21 2015, 1:58 PM
adrianheine removed a project: Patch-For-Review.Jan 22 2015, 1:24 PM

Linked change is merged. Are there more of these?

adrianheine moved this task from Review to Backlog on the § Wikidata-Sprint-2015-01-21 board.Jan 22 2015, 1:24 PM
Tobi_WMDE_SW moved this task from Backlog to Done on the § Wikidata-Sprint-2015-01-21 board.Jan 22 2015, 1:29 PM
Tobi_WMDE_SW moved this task from Done to Backlog on the § Wikidata-Sprint-2015-01-21 board.
Ricordisamoa subscribed.Jan 26 2015, 10:34 AM
adrianheine mentioned this in rEWBA24608b789be0: SnakTypeSelector: Remove 'javascript:void(0);' href.Jan 28 2015, 12:30 PM
Snaterlicious closed this task as Resolved.Jan 29 2015, 8:29 AM
Snaterlicious claimed this task.
Snaterlicious removed Snaterlicious as the assignee of this task.
adrianheine raised the priority of this task from Low to High.Jan 29 2015, 9:58 AM
adrianheine moved this task from Backlog to Done on the § Wikidata-Sprint-2015-01-21 board.
Diffusion mentioned this in rMEXTf2fc7c27c8d1: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Mar 11 2015, 6:25 AM
Addshore closed subtask T56098: [Epic][UI] Front-end performance: Improve loading time of items as Invalid.Sep 21 2021, 8:36 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL