Page MenuHomePhabricator
Create Task
Maniphest T58119

Tag X-CS for 502-16 only if came through Opera Mini proxy
Closed, ResolvedPublic
Actions

Description

See zero.inc.vcl.erb. The Opera *User-Agent* should be the Opera Mini Proxy instead.

Version: master
Severity: normal

Details

Reference
bz56119

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:32 AM
• bzimport added a project: ZeroPortal.
• bzimport set Reference to bz56119.
• bzimport added a subscriber: Unknown Object (MLST).
dr0ptp4kt created this task.Oct 24 2013, 7:43 PM
gerritbot added a comment.Oct 26 2013, 12:33 AM

Change 92038 had a related patch set uploaded by Dr0ptp4kt:
Verify User-Agent versus source proxy for X-CS=502-16. See bug 56119.

https://gerrit.wikimedia.org/r/92038

dr0ptp4kt added a comment.Nov 6 2013, 8:19 PM

A 2% sampling showed that the User-Agent alwasy contained "Opera", so the existing condition seems to be good enough. Nonetheless, once https://gerrit.wikimedia.org/r/#/c/88261 is approved, zero.inc.vcl.erb could be updated to look at X-Forwarded-By instead.

dr0ptp4kt added a comment.Mar 27 2014, 5:14 PM

Identification is now based on source proxy and xff only, in addition to zero subdomain.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL