Page MenuHomePhabricator

Rename tooltip-iwiki to something more consistent with mediawiki terminology
Closed, ResolvedPublic

Description

0d7a30fa27ebaefb5d89693bbe658916b982c082 introduced message key "tooltip-iwiki".

The term or abbreviation "iwiki" doesn't exist and has no meaning in MediaWiki. To avoid more ambiguity (as if we don't have enough confusing and ambiguous *wiki terms) please rename this to something else before the 1.22.0 release.

Filing a bug instead of a commit because this probably needs a little bit of coordination with translatewiki to assure translation history and attribution is preserved. And that part is harder than the commit, so the commit would naturally follow at that point.


Version: 1.22.0
Severity: normal

Details

Reference
bz56129

Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 2:33 AM
bzimport set Reference to bz56129.

This should probably block MW1.22 to avoid people depending on it and turning it into a major headache to fix.

Change 94893 had a related patch set uploaded by Siebrand:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94893

Change 94893 merged by jenkins-bot:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94893

I think I can close this now, and mark this for backporting. Please let me know if I did something wrong...

1.22 is not a stable release yet, so you should just backport the changes to the REL1_22 branch (you can do it using gerrit's "Cherry Pick To" button) and self-merge. I'd do it, but I don't know how such changes are handled by TWN.

(In reply to comment #6)

1.22 is not a stable release yet, so you should just backport the changes to
the REL1_22 branch (you can do it using gerrit's "Cherry Pick To" button) and
self-merge. I'd do it, but I don't know how such changes are handled by TWN.

For 1.22 it's not time critical, so you could have just gone ahead. I'll see if I can cherry pick.

(In reply to comment #7)

For 1.22 it's not time critical, so you could have just gone ahead. I'll see
if I can cherry pick.

Gerrit tells me: Could not create a merge commit during the cherry pick.

(In reply to comment #8)

(In reply to comment #7)
For 1.22 it's not time critical, so you could
have just gone ahead. I'll see
if I can cherry pick.

Gerrit tells me:

Could not create a merge commit during the cherry pick.

Sounds like gerrit 94602 has to cherry pick first to avoid the merge conflict.

Change 94945 had a related patch set uploaded by Bartosz Dziewoński:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94945

I cherry-picked and merged that, and submitted a cherry-pick for this too (see above). I'll let Siebrand/Raimond merge and sort it out at TWN.

Change 94945 merged by MarkAHershberger:
Change interlanguage link title message key

https://gerrit.wikimedia.org/r/94945

Well, I assume Mark knows what he's doing.