Page MenuHomePhabricator
Create Task
Maniphest T58138

Cascade order of fallback CSS properties is wrong
Closed, ResolvedPublic
Actions

Description

Taking a look at the ULS css the css is inconsistent and incorrectly ordered:
https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUniversalLanguageSelector/cf52230d3581b69c7ecacfb256e8f95e8f742ae9/resources%2Fcss%2Fext.uls.css

filter and -ms-filter should be at the very start before any of the gradient rules.

-webkit-gradient and -webkit-linear-gradient should be before linear-gradient.

Also -ms-linear-gradient doesn't exist. At least not outside of the preview version of IE10 no-one should be using since IE10 has a real release.

Version: unspecified
Severity: normal

Details

Reference
bz56138

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:34 AM
• bzimport added a project: UniversalLanguageSelector.
• bzimport set Reference to bz56138.
• bzimport added a subscriber: Unknown Object (MLST).
DanielFriesen created this task.Oct 24 2013, 11:56 PM
DanielFriesen added a comment.Oct 25 2013, 12:03 AM

Also has the use of filter for gradients been properly tested in every version of IE? There are reports of filter and border-radius conflicting in IE9.

Pginer-WMF added a comment.Oct 29 2013, 3:38 PM

The standard (non-prefixed version) should appear at the end. This should be corrected where that is not happening. The issue seems to be present at lines 156, 214, and 268.

I'm not sure -ms-filter position has any practical implications since it is a different property (so overriding should not apply), but I have no idea if there are practical consequences. I would even consider dropping the MS specific -ms-filter prefix since they only add non-essential visual decoration for old browser versions.

Regarding "-ms-linear-gradient", IE seems to support the standard version (where it supports any kind of gradients) according to http://caniuse.com/css-gradients so it makes sense to remove the "-ms-linear-gradient".

siebrand added a comment.Oct 29 2013, 4:31 PM

Submitted a patch upstream for a single usage of "-ms-linear-gradient" in jQuery.ULS: https://github.com/wikimedia/jquery.uls/pull/114

gerritbot added a comment.Oct 29 2013, 4:43 PM

Change 92548 had a related patch set uploaded by Siebrand:
Update order of CSS properties

https://gerrit.wikimedia.org/r/92548

gerritbot added a comment.Oct 30 2013, 12:22 PM

Change 92548 merged by jenkins-bot:
Update order of CSS properties

https://gerrit.wikimedia.org/r/92548

Aklapper added a comment.Feb 14 2014, 12:46 PM

Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Aklapper added a comment.May 20 2014, 10:37 AM

Patch was merged a while ago - is there more work left to do here (if yes: please reset the bug report status to NEW or ASSIGNED), or can you close this ticket as RESOLVED FIXED?

Aklapper added a comment.Aug 17 2014, 11:30 AM

No reply to comment 6 and comment 7 - assuming this bug is FIXED.
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL