Page MenuHomePhabricator
Create Task
Maniphest T58153

MFResourceLoaderModule doesn't always obey debug mode
Closed, ResolvedPublic
Actions

Description

Exception thrown by mobile.stable.common: Cannot call method 'add' of undefined load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10260
TypeError {} load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10266
log load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10266
runScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10486
execute load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10589
handlePending load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10336
markModuleReady load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10460
nestedAddScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10467
runScript load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10477
execute load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10589
mw.loader.implement load.php?debug=true&lang=en&modules=jquery%2Cmediawiki%2CSpinner%7Cjquery.t…Cmw.MwEmbedSupport&only=scripts&skin=vector&version=20131025T025614Z:10971
(anonymous function) load.php?debug=true&lang=en&modules=ext.centralNotice.bannerController%7Cex…ctor.js%7Cwikibase.client.init&skin=vector&version=20131025T101316Z&*:1300

Version: unspecified
Severity: normal

Details

Reference
bz56153

Event Timeline

• bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:35 AM
• bzimport added a project: MobileFrontend-stable.
• bzimport set Reference to bz56153.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Oct 25 2013, 10:15 AM
• bzimport added a comment.Oct 25 2013, 10:16 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1333

Jdlrobson added a comment.Oct 28 2013, 7:58 PM

This is actually not specific to the nearby page and effects mobile pages in debug mode.

Krinkle added a comment.Oct 28 2013, 8:43 PM

Looks like 'target' is missing from ResourceLoaderContext and makeLoaderURL. This probably means that any requests embedded in the HTML are broken (not found) as well if they are restricted by target.

Jdlrobson added a comment.Oct 29 2013, 1:50 AM

Nearby code sets targets as desktop AND mobile so I don't think this is the case.

Can also be replicated on mobile:
https://en.m.wikipedia.org/wiki/Special:Nearby?debug=true

It seems that the load order is not honoured. You'll see mw.template.add("articleList appears before //bits.wikimedia.org/static-1.22wmf22/extensions/MobileFrontend/javascripts/common/templates.js
is injected - and one is plain JavaScript and one is a file path in this url [1]

[1] https://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=ext.centralNotice.bannerController.mobile%2Cmobiledevice%7Cjquery.client%2Ccookie%2Cjson%2CmwExtension%7Cmediawiki.cldr%2CjqueryMsg%2Clanguage%2Cnotify%2Cutil%7Cmediawiki.language.data%2Cinit%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.startup%7Cmobile.head%2CloggingSchemas%2Cnearby%2Cstartup%2Ctemplates%7Cmobile.nearby.scripts%2Cstyles%7Cmobile.stable.common%7Cmobile.toast.styles&skin=vector&version=20131029T013743Z&*

• bzimport added a comment.Oct 29 2013, 1:52 AM

bingle-admin wrote:

Prioritization and scheduling of this bug is tracked on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/mobile/cards/1340

gerritbot added a comment.Nov 7 2013, 6:32 PM

Change 94171 had a related patch set uploaded by Jdlrobson:
Make debug=true work again

https://gerrit.wikimedia.org/r/94171

gerritbot added a comment.Nov 7 2013, 8:09 PM

Change 94171 merged by jenkins-bot:
Make debug=true work again

https://gerrit.wikimedia.org/r/94171

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL