Page MenuHomePhabricator

Crash when displaying an image
Closed, DeclinedPublic

Description

From crash report:

USER_COMMENT=Trying to display an image.
ANDROID_VERSION=4.1.2
APP_VERSION_NAME=1.0
BRAND=samsung
PHONE_MODEL=GT-I9300
CUSTOM_DATA=
STACK_TRACE=java.lang.RuntimeException: An error occured while executing doInBackground()
at android.os.AsyncTask$3.done(AsyncTask.java:299)
at java.util.concurrent.FutureTask$Sync.innerSetException(FutureTask.java:273)
at java.util.concurrent.FutureTask.setException(FutureTask.java:124)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:307)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:856)
Caused by: java.lang.StringIndexOutOfBoundsException: length=0; regionStart=0; regionLength=1
at java.lang.String.startEndAndLength(String.java:593)
at java.lang.String.substring(String.java:1474)
at org.wikimedia.commons.Utils.capitalize(Utils.java:145)
at org.wikimedia.commons.MediaDataExtractor$1.match(MediaDataExtractor.java:193)
at org.wikimedia.commons.MediaDataExtractor.findTemplateParameter(MediaDataExtractor.java:224)
at org.wikimedia.commons.MediaDataExtractor.findTemplateParameter(MediaDataExtractor.java:190)
at org.wikimedia.commons.MediaDataExtractor.processWikiParseTree(MediaDataExtractor.java:116)
at org.wikimedia.commons.MediaDataExtractor.processResult(MediaDataExtractor.java:84)
at org.wikimedia.commons.MediaDataExtractor.fetch(MediaDataExtractor.java:71)
at org.wikimedia.commons.media.MediaDetailFragment$4.doInBackground(MediaDetailFragment.java:194)
at org.wikimedia.commons.media.MediaDetailFragment$4.doInBackground(MediaDetailFragment.java:183)
at android.os.AsyncTask$2.call(AsyncTask.java:287)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
... 4 more
java.lang.StringIndexOutOfBoundsException: length=0; regionStart=0; regionLength=1
at java.lang.String.startEndAndLength(String.java:593)
at java.lang.String.substring(String.java:1474)
at org.wikimedia.commons.Utils.capitalize(Utils.java:145)
at org.wikimedia.commons.MediaDataExtractor$1.match(MediaDataExtractor.java:193)
at org.wikimedia.commons.MediaDataExtractor.findTemplateParameter(MediaDataExtractor.java:224)
at org.wikimedia.commons.MediaDataExtractor.findTemplateParameter(MediaDataExtractor.java:190)
at org.wikimedia.commons.MediaDataExtractor.processWikiParseTree(MediaDataExtractor.java:116)
at org.wikimedia.commons.MediaDataExtractor.processResult(MediaDataExtractor.java:84)
at org.wikimedia.commons.MediaDataExtractor.fetch(MediaDataExtractor.java:71)
at org.wikimedia.commons.media.MediaDetailFragment$4.doInBackground(MediaDetailFragment.java:194)
at org.wikimedia.commons.media.MediaDetailFragment$4.doInBackground(MediaDetailFragment.java:183)
at android.os.AsyncTask$2.call(AsyncTask.java:287)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:856)


Version: unspecified
Severity: critical

Details

Reference
bz56170

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:36 AM
bzimport set Reference to bz56170.

Looks like a bug in MediaDataExtractor, I'll take it.

As the Mobile Apps Team is focussing on the new, native Wikipedia app, the Commons app is no longer being maintained by the Wikimedia Foundation. I am WONTFIXing all open Commons app bugs to reflect that we will not be spending time fixing them.

For the full story, see this thread on mobile-l: https://lists.wikimedia.org/pipermail/mobile-l/2014-September/thread.html#7974