Page MenuHomePhabricator
Create Task
Maniphest T58206

VisualEditor: [Regression] "Watch this" checkbox checked in Save dialog regardless of the user preference
Closed, ResolvedPublic
Actions

Description

I think this is a code regression:

The "Watch this" checkbox is always checked in Save dialog regardless of the user preference.

Version: unspecified
Severity: normal

Details

Reference
bz56206

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:39 AM
• bzimport added projects: VE-deploy-2013-12-05, VisualEditor-MediaWiki.
• bzimport set Reference to bz56206.
Raymond created this task.Oct 26 2013, 8:55 PM
Catrope added a comment.Nov 18 2013, 5:56 AM

Probably solved by https://gerrit.wikimedia.org/r/#/c/95729/ ? That fixes a bug where if you had the 'watchcreations' preference set, "Watch this" would always be checked.

gerritbot added a comment.Nov 18 2013, 10:01 AM

Change 95729 had a related patch set uploaded by Jforrester:
Move setting of minor/watch defaults from MWSaveDialog to Target

https://gerrit.wikimedia.org/r/95729

Jdforrester-WMF added a comment.Nov 19 2013, 6:42 AM
  • Bug 57191 has been marked as a duplicate of this bug. ***
gerritbot added a comment.Nov 25 2013, 5:38 PM

Change 95729 merged by jenkins-bot:
Move setting of minor/watch defaults from MWSaveDialog to Target

https://gerrit.wikimedia.org/r/95729

Jdforrester-WMF added a project: VisualEditor.Dec 3 2014, 2:12 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL