getting rid of BifidExpert
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Danwe
	Oct 28 2013, 5:39 PM

Description

Redefine jQuery.valueview.Expert's draw functions to not be responsible for non-edit mode representation of data values.

For this purpose we should have value formatters in the frontend. Instead of having experts acting as formatters, a formatter factory should be injected into jQuery.valueview widgets just like an ExpertFactory instance is injected there.

This will allow to get rid of the jQuery.valueview.BifidExpert and increase testability of the experts in general as well as reduce their complexity.

Version: unspecified
Severity: normal
Whiteboard: u=dev c=frontend p=13

Details

Reference: bz56259

Related Objects
Search...

Status	Assigned	Task
Declined	None	T59765 Provide JavaScript hook
Resolved	Lydia_Pintscher	T63131 Eliminate or reduce delay between selection of property and displaying of input fields when adding statements
Resolved	None	T58090 Do not change targets to javascript:void(0); on JavaScript load for various "edit" links
Invalid	None	T56098 [Epic][UI] Front-end performance: Improve loading time of items
Resolved	adrianheine	T63739 Expert DOM is re-built several times on page load
Invalid	None	T62341 [Task] Load widgets on demand
Resolved	None	T57693 JavaScript error in BifidExpert: Uncaught TypeError: Cannot call method 'isInEditMode' of null
Resolved	None	T58259 jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpert
Resolved	None	T58263 Implement "ApiBasedValueFormatter" in the fashion of "ApiBasedValueParser"
Resolved	None	T58261 Implementation of basic value formatters in JavaScript
Resolved	None	T58765 create an api module for formatting data values
Resolved	None	T59014 Create a FormatValue API module for formatting data values

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM

• bzimport added projects: MediaWiki-extensions-WikibaseRepository, JavaScript.

• bzimport set Reference to bz56259.

• bzimport added a subscriber: Unknown Object (MLST).

Danwe created this task.Oct 28 2013, 5:39 PM

I don't agree with this bug's current severity/priority rating at all. This is the kind of continuous refactoring that is required to not end up with a huge mess after the next two features got implemented into the component.

Currently we already have a huge mess in the Time/Geo experts, this could be a first step into improving the situation.

jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpertClosed, ResolvedPublicActions

Description

Details

Related ObjectsSearch...

Event Timeline

jQuery.valueview.Expert.prototype.draw() should not be responsible for non-edit mode >> getting rid of BifidExpert
Closed, ResolvedPublic
Actions

Related Objects
Search...