[Regression] Missing "media => screen" breaks Vector styles for printing
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Schnark
	Oct 30 2013, 10:03 AM

Description

https://gerrit.wikimedia.org/r/#/c/79948/ removed the "media => screen" for vector/styles.less (See http://bits.wikimedia.org/en.wikipedia.org/load.php?debug=true&lang=en&modules=skins.vector&only=styles&skin=vector, the second part isn't wrapped in any @media clause). These styles now override the styles for printing, which is bad. Most noticeably:

The font changed from serif (browser default) to sans-serif.
The font size is smaller than before.
Bulleted lists use colored bullets.

Please add the "media => screen" for these styles, or - if there are styles that should explicitly apply for printing, too, split them into a separate file.

Version: 1.22.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=56592

Details

Reference: bz56366

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 2:21 AM

• bzimport added projects: MW-1.22.0-release, MediaWiki-User-Interface.

• bzimport set Reference to bz56366.

Schnark created this task.Oct 30 2013, 10:03 AM

Change 92658 had a related patch set uploaded by Jdlrobson:
Add missing media screen

https://gerrit.wikimedia.org/r/92658

Change 92672 had a related patch set uploaded by Bartosz Dziewoński:
Add missing media screen

https://gerrit.wikimedia.org/r/92672

Fixed by Jon, backported to 1.22 release. Thanks Michael, we'd love to have more bug reporters like you :D

It was removed because Jon merged the vector-hd styles into the same less file. That means the module style file *must not* have 'media' set, otherwise it will end up beig nested, which browsers do not support.

I'm confused Krinkle why have you reopened this? Your patch looks identical..

(me now super confused at the 3 identical patches)

The patches were not merged, and there are only two, one for master and one for REL1_22.

The german-speaking community is concerned that printing wikipedia articles is now much harder then before (at least the reading). Could this bug please fixed soon or the patch, that introduce the problem, reverted?

Change 93408 had a related patch set uploaded by Jdlrobson:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93408

Change 92672 abandoned by Bartosz Dziewoński:
Add missing media screen

Reason:
Superseded by https://gerrit.wikimedia.org/r/#/c/93408/1

https://gerrit.wikimedia.org/r/92672

Change 92658 abandoned by Bartosz Dziewoński:
Vector: Set media=screen on styles.less

Reason:
Superseded by https://gerrit.wikimedia.org/r/#/c/93408/1

https://gerrit.wikimedia.org/r/92658

Change 93412 had a related patch set uploaded by Bartosz Dziewoński:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93412

Change 93408 merged by jenkins-bot:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93408

Change 93412 merged by jenkins-bot:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93412

All merged and backported. (So many automated comments.)

Jon said he will try to get the patch deployed to Wikimedia wikis tomorrow.
If that doesn't happen, it will be deployed during regular deployments (within about two weeks).

Change 93612 had a related patch set uploaded by Mwalker:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93612

Change 93613 had a related patch set uploaded by Mwalker:
Vector: Set media screen on styles.less

https://gerrit.wikimedia.org/r/93613

Change 93613 merged by Mwalker:
Vector: Set media screen on styles.less