Page MenuHomePhabricator
Create Task
Maniphest T58371

Various variables including "summary" "new_wikitext" for section=new are not calculated correctly
Closed, InvalidPublic
Actions

Description

Currently tt's the title of the section being added "section name", but the real summary is "/* section name */ new section".

Version: unspecified
Severity: normal

Details

Reference
bz56371

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:22 AM
• bzimport added a project: AbuseFilter.
• bzimport set Reference to bz56371.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Oct 30 2013, 11:39 AM
liangent added a comment.Oct 30 2013, 5:20 PM

Affected variables are more than a single "summary". Section header is missing in "new_wikitext", causing all "delta variables" to be wrong.

Aklapper added a comment.Oct 31 2013, 6:00 PM

How could I try to reproduce this?

liangent added a comment.Nov 1 2013, 1:24 AM

(In reply to comment #2)

How could I try to reproduce this?

Have AF block your section=new edit and check AbuseLog.

• werdna unsubscribed.Dec 10 2014, 5:24 PM
Daimona merged a task: T47272: Creating new section makes summary inconsistent between testing and real abuse filter application.Mar 27 2018, 5:58 PM
Daimona added subscribers: Mormegil, Danny_B.
Daimona subscribed.Apr 8 2018, 1:02 PM

Actually, only the summary is wrong, since it doesn't include the comment. I'll see how difficult it is to solve this.

Daimona closed this task as Invalid.Apr 8 2018, 1:22 PM
Daimona mentioned this in T191722: EditFilterMergedContent hook shows summary without comment for new sections.

Not AF's fault, further explanation in T191722. This task is totally dependent on that, and a change at Hook level will fix this AF behaviour without the need of any further change to AF.

Daimona mentioned this in T208092: Implement "Creating new section" variable.Oct 26 2018, 8:25 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL