Page MenuHomePhabricator

Exit lightbox when clicking on backdrop
Closed, DeclinedPublic

Description

Suggestion from legoktm - should be fairly easy.


Version: unspecified
Severity: enhancement

Details

Reference
bz56402

Event Timeline

bzimport raised the priority of this task from to Low.Nov 22 2014, 2:24 AM
bzimport set Reference to bz56402.

(In reply to comment #0)

Suggestion from legoktm - should be fairly easy.

Please use comment 0, also known as the bug description, to describe the bug.

@mark: Please elaborate the same so that someone can work on it please.

Sorry! The idea is, if someone clicks on the black area behind the image, the lightbox should close. There are already close methods that are fairly general, so the only work involved *should* be adding an event listener in the right spot, and clearing it properly.

Let me know if you need any help :)

Change 103902 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/103902

Change 108317 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317

Change 103902 abandoned by 01tonythomas:
Exit Lightbox when clicked on backdrop

Reason:
persistent rebase errors
Continued in
https://gerrit.wikimedia.org/r/#/c/108317/

https://gerrit.wikimedia.org/r/103902

Change 108317 merged by jenkins-bot:
Exit Lightbox when clicked on backdrop

https://gerrit.wikimedia.org/r/108317

Change 118667 had a related patch set uploaded by 01tonythomas:
Exit Lightbox when clicked on Backdrop

https://gerrit.wikimedia.org/r/118667

For good reason.

We decided that this causes way too many accidental lightbox close events, and reverted.

WONTFIXing for now - we may revisit this later, but it won't be for the next few months.

Change 118667 abandoned by MarkTraceur:
Exit Lightbox when clicked on Backdrop

Reason:
We tried doing this once before, it was just confusing and overall interfered with other actions in the viewer.

https://gerrit.wikimedia.org/r/118667

Gilles raised the priority of this task from Low to Unbreak Now!.Dec 4 2014, 10:12 AM
Gilles moved this task from Untriaged to Done on the Multimedia board.
Gilles lowered the priority of this task from Unbreak Now! to Low.Dec 4 2014, 11:22 AM