For accessibility and general helpfulness, the close and fullscreen buttons should have a title attribute which can be shown as a tooltip on hover or spoken when a screen reader is in use.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz56471
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Krinkle | T152476 mw.language unittest cleanup failing | |||
| Resolved | • Prtksxna | T58471 Close and zoom buttons have no tooltips or speakable title (title attribute) |
Event Timeline
Comment Actions
Change 105459 had a related patch set uploaded by Apsdehal:
Tooltips added to fullscreen and cloase button
Comment Actions
Screen readers generally prefer alt over title. Also, I'm not sure we want the tooltips to show up, they are ugly, and meaning the buttons (these two anyway) are quite obvious. But even if we want them, then we should set both alt and title.
Comment Actions
Change 105459 abandoned by Gilles:
Title properties added to some buttons in lbinterface
Reason:
I think that now almost all the buttons in the interface have a tipsy message.
Comment Actions
Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team.
Comment Actions
It looks like tooltips have already been added in rEMMVea610f8256f96e5e7909991049298dc9866a15e3. Is this still an issue?
Comment Actions
Huh, indeed. Maybe you could add popups for prev/next buttons, that seems to be the only missing one.
Comment Actions
Those were removed in rEMMV532819b5a0dca69409c4696dae3d18cbf6029389. I couldn't find an accompanying bug/task but I assume they were deemed to be excessive?
Comment Actions
No clue. @MarkTraceur do you remember what that was about?
In any case, there should be an alt tag at least, or an ARIA role marking it as a button, or something; it is the most important control after closing, and it is not accessible at all now. Unfortunately I don't know much about accessibility so I hope someone can take this over. @TheDJ or @Volker_E maybe?
Comment Actions
Change 326146 had a related patch set uploaded (by Sn1per):
Add alt text attributes to all of the lightbox buttons
Comment Actions
Change 326146 merged by jenkins-bot:
Add alt text attributes to all of the lightbox buttons
Comment Actions
Patch 326146 is a misconception and doesn't help. The alt attribute is only allowed on img and area tags and optional on (image) input (buttons) and will be ignored in accessibility tree.
@Tgr We should (partly) revert that change and go for something either using the Less helper [[ https://phabricator.wikimedia.org/diffusion/MW/browse/master/resources/src/mediawiki.less/mediawiki.mixins.less;fbb1f742435c1d1eb3b31bf980e0682fc509b8c2$121 | .mixin-screen-reader-text() ]] or a similar approach for visually hiding text for assistive technology.
Comment Actions
Adding to above, title attribute might help as well.
In general we shouldn't redo semantics. Using semantic button for a button element is helpful for assistive technology as well. See http://www.powermapper.com/tests/screen-readers/attributes/index.html
Comment Actions
Just rename alt to aria-label? That should be usable on any element.
title is user-visible and was removed at some point from the navigation controls, as @Sn1per said.
Comment Actions
Ok, I seemingly have skipped the part about unwanted user visibility.
I'd recommend using button instead of div and go for text just visible to screen readers.
Comment Actions
@Volker_E Probably useful to update the description with what is remaining on this task too.
Comment Actions
Change 343441 had a related patch set uploaded (by Prtksxna):
[mediawiki/extensions/MultimediaViewer] Use <button> instead of <div>
Comment Actions
Change 343441 merged by jenkins-bot:
[mediawiki/extensions/MultimediaViewer@master] Use <button> instead of <div>