Page MenuHomePhabricator

Parsoid: [REGRESSION] content attribute missing from defaultsort tags
Closed, ResolvedPublic

Description

Before https://gerrit.wikimedia.org/r/#/c/90449 :

<meta property="mw:PageProp/categorydefaultsort" content="Page, Main" data-parsoid='{"src":"{{DEFAULTSORT:Page, Main}}","dsr":[1800,1826,null,null]}'/>

After:

<meta property="mw:PageProp/categorydefaultsort" data-parsoid='{"src":"{{DEFAULTSORT:Page, Main}}","a":{"content":null},"sa":{"content":"Page, Main"},"dsr":[1800,1826,null,null]}'/>

This breaks editing of defaultsort in VisualEditor for obvious reasons, but it also triggers a failure mode in VisualEditor where missing content attributes aren't expected and are normalized to content="null", triggering corruption warnings and changing {{DEFAULTSORT:Foo}} to {{DEFAULTSORT:null}}. I'll fix that in VE.


Version: unspecified
Severity: normal

Details

Reference
bz56489

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 2:31 AM
bzimport added a project: Parsoid.
bzimport set Reference to bz56489.

Change 93108 had a related patch set uploaded by GWicke:
Bug 56489: Allow content attribute on parsoid-generated meta tokens

https://gerrit.wikimedia.org/r/93108

Change 93108 merged by jenkins-bot:
Bug 56489: Allow content attribute on parsoid-generated meta tokens

https://gerrit.wikimedia.org/r/93108