Page MenuHomePhabricator
Create Task
Maniphest T58617

VisualEditor: Hover effect inconsistent for Help icon
Closed, DeclinedPublic
Actions

Description

Noticed on mediawiki.org, currently at 1.23wmf2 (rMW88c7b3fee763)

On hover, the Help icon in the VisualEditor toolbar gets both the light gray border with all corners rounded, and the darker gray border that, if I look at the Menu icon for reference, should probably only appear when the button is pressed, not just hovered.

Furthermore, the dark gray border only has the left corners rounded.

Version: unspecified
Severity: trivial

Details

Reference
bz56617

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 2:40 AM
• bzimport added a project: VisualEditor-MediaWiki.
• bzimport set Reference to bz56617.
gpaumier created this task.Nov 5 2013, 12:59 PM
Esanders added a comment.Nov 5 2013, 4:45 PM

The behaviour is correct because the help icon is actually in a group with the notification icon, however the notification icon is hidden when there are no notifications. This is also the cause of the rounded corners problem, as the CSS renderer doesn't match the last-child rule if the next child is hidden.

Solutions:

  • Group help and notifications with the hamburger menu. This avoids the rounded corners problem, and the issue of the colours looking wrong because it is a set of one, but is hacky.
  • Destroy the notifications icon when not in use. This would involve a bit of a rewrite as in theory it's possible to push notifications after load and the button should appear when this happens.
  • Ungroup help and notifications. This avoids all the problems here.
Jdforrester-WMF added a project: VisualEditor.Nov 24 2014, 4:08 PM
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Nov 24 2014, 4:15 PM
matmarex subscribed.Feb 16 2017, 2:06 AM

This doesn't appear to be a problem anymore (not even on MonoBook, which still uses the original toolbar design), or I'm misunderstanding your description. In the future, please file bugs with screenshots. :(

gpaumier unsubscribed.Jul 18 2018, 5:57 PM
matmarex closed this task as Declined.Jul 11 2019, 5:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL