Page MenuHomePhabricator
Create Task
Maniphest T58657

Donate via PayPal from [[wmf:Ways to Give]] says "Please correct the errors in your donation amount"
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

Repro:

  1. Go to https://wikimediafoundation.org/wiki/Ways_to_Give
  2. Click "U.S. dollar (USD)" in PayPal section

Actual:

  1. It says "Please correct the errors in your donation amount" in the next page

Expected:

  1. "Please enter your donation amount" or nothing at all. Actually the donor did nothing wrong.

Version: unspecified
Severity: normal

Details

Reference
bz56657
SubjectRepoBranchLines +/-
Fix regression with zero-amount errormediawiki/extensions/DonationInterfacemaster+16 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:11 AM
• bzimport added a project: MediaWiki-extensions-DonationInterface.
• bzimport set Reference to bz56657.
• bzimport added a subscriber: Unknown Object (MLST).
liangent created this task.Nov 6 2013, 5:24 AM
Aklapper added a comment.Dec 17 2013, 10:34 AM

Confirming.

Pcoombe added a comment.Jan 22 2014, 4:30 PM

Tracked on Mingle: https://wikimedia.mingle.thoughtworks.com/projects/online_fundraiser/cards/1334

gerritbot added a comment.Jun 24 2014, 9:34 PM

Change 141826 had a related patch set uploaded by Ejegg:
Show friendlier error message for zero donation amount

https://gerrit.wikimedia.org/r/141826

gerritbot added a comment.Jun 25 2014, 6:04 PM

Change 141826 merged by Awight:
Show friendlier error message for zero donation amount

https://gerrit.wikimedia.org/r/141826

gerritbot added a comment.Jun 29 2014, 3:17 PM

Change 142890 had a related patch set uploaded by Awight:
Show friendlier error message for zero donation amount

https://gerrit.wikimedia.org/r/142890

gerritbot added a comment.Jun 29 2014, 3:32 PM

Change 142890 merged by jenkins-bot:
Show friendlier error message for zero donation amount

https://gerrit.wikimedia.org/r/142890

Pcoombe reopened this task as Open.Mar 26 2015, 6:19 PM

Re-opening, this is happening again. Not sure if it's due to the DonationInterface refactor a few weeks ago, or the subsequent changes to fix T92705.

Pcoombe added a project: Fundraising-Backlog.Mar 26 2015, 6:20 PM
Pcoombe set Security to None.
• CCogdill_WMF added subscribers: Juro2351, • CCogdill_WMF.Mar 26 2015, 6:31 PM
awight added a comment.Mar 26 2015, 9:29 PM

I think this regressed a while ago, actually, when I did some DataValidator cleanup. Looks like commit a24f68fb385a0e76fd1b478a61c4b06cd8edfe9c, 29 Jan 2015.

gerritbot subscribed.Mar 26 2015, 9:36 PM

Change 200031 had a related patch set uploaded (by Awight):
Fix regression with zero-amount error

https://gerrit.wikimedia.org/r/200031

gerritbot added a project: Patch-For-Review.Mar 26 2015, 9:36 PM
awight added a project: Fundraising Sprint Grandmaster Flash.Mar 26 2015, 9:36 PM
awight edited a custom field.
awight moved this task from Backlog to Review on the Fundraising Sprint Grandmaster Flash board.
• atgo assigned this task to awight.Mar 26 2015, 9:40 PM
• atgo edited a custom field.
gerritbot added a comment.Mar 26 2015, 11:49 PM

Change 200031 merged by jenkins-bot:
Fix regression with zero-amount error

https://gerrit.wikimedia.org/r/200031

awight mentioned this in rMEXTf6f76829338d: Updated mediawiki/extensions Project: mediawiki/extensions/DonationInterface….Mar 26 2015, 11:50 PM
awight mentioned this in rEDOIb145d566f21e: Fix regression with zero-amount error.
Pcoombe closed this task as Resolved.Mar 27 2015, 12:23 PM

Great, it's working for me now. Thanks @awight!

awight moved this task from Review to Done on the Fundraising Sprint Grandmaster Flash board.Mar 30 2015, 9:41 PM
• DStrine moved this task from Triage to Closed Sprint Work Q3 1415 on the Fundraising-Backlog board.Jun 25 2015, 4:38 PM
• mmodell removed a subscriber: awight.Jun 22 2017, 9:52 PM
• DStrine edited projects, added Fr-tech-archived-from-FY-2014/15; removed Fundraising-Backlog.Jan 11 2018, 9:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL